[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765785#comment-16765785
]
Weiwei Yang commented on YARN-9191:
---
Just cherry picked to branch-3.2 and branch-3.1.
> Add cli option
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765722#comment-16765722
]
Weiwei Yang commented on YARN-9191:
---
Thanks [~abmodi], the patch can be cherry picked to branch-3.2 and
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764875#comment-16764875
]
Abhishek Modi commented on YARN-9191:
-
[~cheersyang] I will soon upload patches for branch-3,
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764697#comment-16764697
]
Weiwei Yang commented on YARN-9191:
---
Hi [~giovanni.fumarola]
The fix version of YARN-5180 is 3.0, can
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757897#comment-16757897
]
Abhishek Modi commented on YARN-9191:
-
Thanks [~elgoiri] and [~giovanni.fumarola].
> Add cli option
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757656#comment-16757656
]
Giovanni Matteo Fumarola commented on YARN-9191:
Thanks [~abmodi] for the patch and
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757655#comment-16757655
]
Hudson commented on YARN-9191:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15862 (See
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757576#comment-16757576
]
Íñigo Goiri commented on YARN-9191:
---
+1 on [^YARN-9191.006.patch].
> Add cli option in DS to support
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756820#comment-16756820
]
Abhishek Modi commented on YARN-9191:
-
[~elgoiri] all the test passes locally for me.
> Add cli
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756552#comment-16756552
]
Íñigo Goiri commented on YARN-9191:
---
[^YARN-9191.006.patch] looks good.
However the Yetus run doesn't
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756483#comment-16756483
]
Hadoop QA commented on YARN-9191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755081#comment-16755081
]
Íñigo Goiri commented on YARN-9191:
---
[^YARN-9191.005.patch] pretty much looks like it.
One minor thing,
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754971#comment-16754971
]
Hadoop QA commented on YARN-9191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754363#comment-16754363
]
Íñigo Goiri commented on YARN-9191:
---
{code}
One getAppAttempt is done after containers are running to
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754209#comment-16754209
]
Abhishek Modi commented on YARN-9191:
-
Thanks [~elgoiri] for review:
Why do we do getAppAttempts() in
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754170#comment-16754170
]
Íñigo Goiri commented on YARN-9191:
---
Thanks [~abmodi] for [^YARN-9191.004.patch].
* Why do we do
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753584#comment-16753584
]
Hadoop QA commented on YARN-9191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753456#comment-16753456
]
Hadoop QA commented on YARN-9191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745405#comment-16745405
]
Íñigo Goiri commented on YARN-9191:
---
Thanks [~abmodi] for the test.
You may want to add a limit to the
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745018#comment-16745018
]
Hadoop QA commented on YARN-9191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742346#comment-16742346
]
Íñigo Goiri commented on YARN-9191:
---
Yes, it looks like {{testDSShellWithOpportunisticContainers()}}
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741456#comment-16741456
]
Abhishek Modi commented on YARN-9191:
-
[~elgoiri] thanks for review.
Yes, I could let the exception
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741436#comment-16741436
]
Íñigo Goiri commented on YARN-9191:
---
Instead of catching and failing, you could just let the exception
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741130#comment-16741130
]
Abhishek Modi commented on YARN-9191:
-
All the tests are passing locally. [~elgoiri]
[
https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740023#comment-16740023
]
Hadoop QA commented on YARN-9191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
25 matches
Mail list logo