[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762738#comment-16762738 ] Jim Brennan commented on YARN-9206: --- The new patches look good to me.   > RMServerUtil

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762591#comment-16762591 ] Hadoop QA commented on YARN-9206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762575#comment-16762575 ] Hadoop QA commented on YARN-9206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762488#comment-16762488 ] Sunil Govindan commented on YARN-9206: -- re attached branch-3.1 patch to run jenkins a

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762475#comment-16762475 ] Hadoop QA commented on YARN-9206: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761251#comment-16761251 ] Kuhu Shukla commented on YARN-9206: --- Thank you [~sunilg] for the commit and the review.

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759668#comment-16759668 ] Sunil Govindan commented on YARN-9206: -- [~kshukla] Thanks. I could commit to trunk a

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759667#comment-16759667 ] Hudson commented on YARN-9206: -- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #158

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757915#comment-16757915 ] Sunil Govindan commented on YARN-9206: -- +1. Test case failures are not related and tr

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757754#comment-16757754 ] Hadoop QA commented on YARN-9206: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757718#comment-16757718 ] Jim Brennan commented on YARN-9206: --- [~kshukla] thanks for the new patch.   This looks g

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756075#comment-16756075 ] Kuhu Shukla commented on YARN-9206: --- Thank you [~sunilg], will update patch shortly. >

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755646#comment-16755646 ] Sunil Govindan commented on YARN-9206: -- Sorry for the delay here.  Yes, addAll has s

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751227#comment-16751227 ] Jim Brennan commented on YARN-9206: --- [~sunilg], [~kshukla]  While I agree that [~sunilg]

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750881#comment-16750881 ] Sunil Govindan commented on YARN-9206: -- Thanks [~kshukla] This logic seems better as

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750094#comment-16750094 ] Kuhu Shukla commented on YARN-9206: --- Spoke to [~Jim_Brennan] offline and he clarified wi

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749507#comment-16749507 ] Sunil Govindan commented on YARN-9206: -- Thanks [~kshukla] I am kind of more leaning

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749483#comment-16749483 ] Hadoop QA commented on YARN-9206: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749361#comment-16749361 ] Kuhu Shukla commented on YARN-9206: --- Thank you [~sunilg] for the review. I was not super

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749358#comment-16749358 ] Sunil Govindan commented on YARN-9206: -- Hi [~kshukla] Thanks for the patch. I think

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749333#comment-16749333 ] Kuhu Shukla commented on YARN-9206: --- Complexity is a bit worse but I tried not to add an

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749140#comment-16749140 ] Kuhu Shukla commented on YARN-9206: --- I see! Will update patch shortly. > RMServerUtils

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749132#comment-16749132 ] Jim Brennan commented on YARN-9206: --- {quote}{quote}I think you need to iterate the accep

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749021#comment-16749021 ] Kuhu Shukla commented on YARN-9206: --- Thank you [~Jim_Brennan] for the review! bq. I thin

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748895#comment-16748895 ] Jim Brennan commented on YARN-9206: --- [~kshukla], thanks for the patch!  I think it would

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746716#comment-16746716 ] Hadoop QA commented on YARN-9206: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746600#comment-16746600 ] Kuhu Shukla commented on YARN-9206: --- Thank you for the comments [~leftnoteasy], I guess

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745628#comment-16745628 ] Wangda Tan commented on YARN-9206: -- [~kshukla], could u please add a method to NodeState

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745595#comment-16745595 ] Kuhu Shukla commented on YARN-9206: --- Patch needs a test still, but just to get things go