[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792721#comment-16792721 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793322#comment-16793322 ] Devaraj K commented on YARN-9267: - Sorry for coming in late. Thanks [~pbacsko] for the pa

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794947#comment-16794947 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] thanks for the tip, will check this

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795057#comment-16795057 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795068#comment-16795068 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] please check patch v6 which should b

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795132#comment-16795132 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795669#comment-16795669 ] Devaraj K commented on YARN-9267: - Thanks [~pbacsko] for the patch, latest patch has gone

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795916#comment-16795916 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] yes there was a commit in the meanti

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795981#comment-16795981 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796011#comment-16796011 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] I think now you can submit the patch

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796800#comment-16796800 ] Devaraj K commented on YARN-9267: - Thanks [~pbacsko] for updating the patch. * FpgaResour

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797023#comment-16797023 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] the reason I introduced the method r

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797302#comment-16797302 ] Devaraj K commented on YARN-9267: - bq. It's usually a good practice to do in unit tests, b

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797635#comment-16797635 ] Peter Bacsko commented on YARN-9267: [~devaraj.k] modified the patch as you requested.

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797641#comment-16797641 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797741#comment-16797741 ] Devaraj K commented on YARN-9267: - Please remove this log message, it makes to double log

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798016#comment-16798016 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798229#comment-16798229 ] Devaraj K commented on YARN-9267: - Thanks [~pbacsko] for updating the patch, can you also

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798235#comment-16798235 ] Peter Bacsko commented on YARN-9267: Ah sure, didn't see that. Will fix it in a minute

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798298#comment-16798298 ] Hadoop QA commented on YARN-9267: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798312#comment-16798312 ] Devaraj K commented on YARN-9267: - +1, latest patch looks good to me, committing it shortl

[jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl

[ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798323#comment-16798323 ] Hudson commented on YARN-9267: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #162