[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823933#comment-16823933 ] Hudson commented on YARN-9475: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #164

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-23 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823878#comment-16823878 ] Zhankun Tang commented on YARN-9475: [~pbacsko], [~sunilg]. Thanks. Make sense to me.

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-23 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823873#comment-16823873 ] Peter Bacsko commented on YARN-9475: IMO it's OK to move forward with the current solu

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-23 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823845#comment-16823845 ] Sunil Govindan commented on YARN-9475: -- [~tangzhankun] thanks for looking into this. 

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-19 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821750#comment-16821750 ] Zhankun Tang commented on YARN-9475: [~sunilg] Thanks for the review. It looks good to

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-18 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821089#comment-16821089 ] Sunil Govindan commented on YARN-9475: -- +1 from me. Looks good. [~tangzhankun], cud

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821007#comment-16821007 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820957#comment-16820957 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-18 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820885#comment-16820885 ] Peter Bacsko commented on YARN-9475: Thanks for the comments [~sunilg]. 1. Fixed 2. F

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820340#comment-16820340 ] Sunil Govindan commented on YARN-9475: -- Thanks [~pbacsko]. Few comments # Below code

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819458#comment-16819458 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819222#comment-16819222 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-16 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819129#comment-16819129 ] Peter Bacsko commented on YARN-9475: _Btw, I can see that this.binaryPath is modified

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-16 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819051#comment-16819051 ] Peter Bacsko commented on YARN-9475: Thanks [~snemeth] very reasonable comments. I'm w

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-16 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818945#comment-16818945 ] Szilard Nemeth commented on YARN-9475: -- Thanks [~pbacsko] for this patch! Couple of

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-15 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818012#comment-16818012 ] Peter Bacsko commented on YARN-9475: Note: I modified the script discovery logic sligh

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-15 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818008#comment-16818008 ] Peter Bacsko commented on YARN-9475: [~snemeth] please review the patch. I believe th

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817955#comment-16817955 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817847#comment-16817847 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-15 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817678#comment-16817678 ] Peter Bacsko commented on YARN-9475: I addressed checktyle & findbugs warnings. Note

[jira] [Commented] (YARN-9475) Create basic VE plugin

2019-04-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816268#comment-16816268 ] Hadoop QA commented on YARN-9475: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||