Xuan Gong created YARN-6922:
-------------------------------
Summary: Findbugs warning in YARN NodeManager
Key: YARN-6922
URL: https://issues.apache.org/jira/browse/YARN-6922
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 3.0.0-beta1
Reporter: Xuan Gong
Several findbugs warning in YARN NodeManager package.
{code}
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics.usageMetrics
is a mutable collection which should be package protected
Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details)
In class
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics
Field
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics.usageMetrics
At ContainerMetrics.java:[line 134]
{code}
{code}
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.createStatus()
makes inefficient use of keySet iterator instead of entrySet iterator
Bug type WMI_WRONG_MAP_ITERATOR (click for details)
In class
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer
In method
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.createStatus()
Field
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.pendingResources
At ContainerLocalizer.java:[line 357]
{code}
{code}
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeVeryOldStoppedContainersFromCache()
makes inefficient use of keySet iterator instead of entrySet iterator
Bug type WMI_WRONG_MAP_ITERATOR (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl
In method
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeVeryOldStoppedContainersFromCache()
Field
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.recentlyStoppedContainers
At NodeStatusUpdaterImpl.java:[line 719]
{code}
{code}
Hard coded reference to an absolute pathname in
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
Bug type DMI_HARDCODED_ABSOLUTE_FILENAME (click for details)
In class
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime
In method
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
File name /sys/fs/cgroup
At DockerLinuxContainerRuntime.java:[line 490]
{code}
{code}
Useless object stored in variable removedNullContainers of method
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)
Bug type UC_USELESS_OBJECT (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl
In method
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)
Value removedNullContainers
Type java.util.HashSet
At NodeStatusUpdaterImpl.java:[line 642]
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
