No worries, thanks for the update!
On Fri, Jun 3, 2022, 10:54 AM Richard Purdie <
richard.pur...@linuxfoundation.org> wrote:
> On Thu, 2022-05-12 at 17:39 +0100, Abongwa Amahnui Bonalais wrote:
> > Script to add banners to the old docs and outdated dunfell docs
> >
>
Script to add banners to the old docs and outdated dunfell docs
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 83 ++
scripts/run-docs-build | 2 +
2 files changed, 85 insertions(+)
create mode 100755 scripts/docs_add_banner.py
On Thu, May 12, 2022 at 01:42 PM, Quentin Schulz wrote:
>
>
> On 5/12/22 14:33, Abongwa Amahnui Bonalais wrote:
>
>> Script to add banners to the old docs and outdated dunfell docs
>> Signed-off-by: Abongwa Bonalais Amahnui
>
> Reviewed-by: Quentin Schulz
>
Script to add banners to the old docs and outdated dunfell docs
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 84 ++
scripts/run-docs-build | 2 +
2 files changed, 86 insertions(+)
create mode 100755 scripts/docs_add_banner.py
Script to add banners to the old docs and outdated dunfell docs
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 84 ++
scripts/run-docs-build | 6 ++-
2 files changed, 88 insertions(+), 2 deletions(-)
create mode 100755
On Thu, May 12, 2022 at 09:23 AM, Quentin Schulz wrote:
>
> Not quite happy with this comment as I still don't understand why this was
> needed.
>
> What is the issue with "any .body property existing in any css file
> [being] overwritten"?
>
> I am not going to fight it too much as we really
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 84 ++
scripts/run-docs-build | 2 +
2 files changed, 86 insertions(+)
create mode 100644 scripts/docs_add_banner.py
diff --git a/scripts/docs_add_banner.py
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 84 ++
scripts/run-docs-build | 2 +
2 files changed, 86 insertions(+)
create mode 100644 scripts/docs_add_banner.py
diff --git a/scripts/docs_add_banner.py
On Thu, May 5, 2022 at 09:03 PM, Richard Purdie wrote:
>
> One small thing, shouldn't we write the files with the same encoding as we
> read
> them?
thank you for this, I adjusted it the most recent patch
>
> On 5/10/22 18:46, Abongwa Amahnui Bonalais wrote:
>
>
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 84 ++
scripts/run-docs-build | 2 +
2 files changed, 86 insertions(+)
create mode 100644 scripts/docs_add_banner.py
diff --git a/scripts/docs_add_banner.py
Hello Richard,
Thanks for the review
>
> I think Quentin also mentioned that these two loop functions can be merged
> together to form simpler code with a condition in the centre section?
I'm sorry I don't understand how to implement this as I tried using a function
in the code but then the
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_add_banner.py | 104 +
scripts/run-docs-build | 2 +
2 files changed, 106 insertions(+)
create mode 100644 scripts/docs_add_banner.py
diff --git a/scripts/docs_add_banner.py
Hi Quentin
On Tue, May 3, 2022 at 10:51 AM, Quentin Schulz wrote:
>
>
>> +
>> +
>> +
>> +def dunfell_tags(dir):
>> + dunfell_banners = []
>> + for root, dirs, filenames in os.walk(dir):
>> + dunfell_banners = [ name for name in os.listdir(dir) if not
>> name.startswith('3.1') ]
>> + for d in
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_fix_all_html_css.py | 111 +++
scripts/run-docs-build | 2 +
2 files changed, 113 insertions(+)
create mode 100644 scripts/docs_fix_all_html_css.py
diff --git a/scripts/docs_fix_all_html_css.py
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_fix_all_html_css.py | 107 +++
scripts/run-docs-build | 2 +
2 files changed, 109 insertions(+)
create mode 100644 scripts/docs_fix_all_html_css.py
diff --git a/scripts/docs_fix_all_html_css.py
Hi Quentin,
Thanks for the review.
I tried using regex to look for all the folders prefixed by 3.1. but it is
currently not working, But I am still working on a fix for it.
I noticed that the banner was already on the dunfell excluding 3.1.15, so
should I hardcode from 3.1 to 3.1.14 while
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_fix_all_html_css.py | 75
scripts/run-docs-build | 2 +
2 files changed, 77 insertions(+)
create mode 100755 scripts/docs_fix_all_html_css.py
diff --git a/scripts/docs_fix_all_html_css.py
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_fix_all_html_css.py | 75
scripts/run-docs-build | 2 +
2 files changed, 77 insertions(+)
create mode 100755 scripts/docs_fix_all_html_css.py
diff --git a/scripts/docs_fix_all_html_css.py
>
> Hardcoding numbers like this isn’t a great idea. If the intention is to
> add the warning on all versions earlier than 3.2, then the regex approach
> that is commented out would be better. It most likely didn’t work as regex
> matching isn’t like shell/windows matching: pattern = r”^3\.1.*" A
Signed-off-by: Abongwa Bonalais Amahnui
---
scripts/docs_fix_all_html_css.py | 85
scripts/run-docs-build | 1 +
2 files changed, 86 insertions(+)
create mode 100755 scripts/docs_fix_all_html_css.py
diff --git a/scripts/docs_fix_all_html_css.py
Hi Quentin,
I'm sorry for taking so long
I'm still trying to figure out how to prevent the script from writing into the
3.1 versions and above.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56850):
On Fri, Apr 22, 2022 at 04:07 PM, Quentin Schulz wrote:
>
> Would you mind telling us how you created your patch from a commit so we
> can help you fix the issue there?
I'm sorry I added the run-docs-build manually to another folder after testing
it so that I could easily track it, I did not
Hi Quentin,
I sent a more recent patch containing the changes you requested.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56847): https://lists.yoctoproject.org/g/yocto/message/56847
Mute This Topic:
Also added a command in the run-docs-build file to run the python script once
in the extracted tarball directory.
Signed-off-by: Abongwa Bonalais Amahnui
---
docs_fix_all_html_css.py | 79
run-docs-build | 2 +
2 files changed, 81
>
> A better name would be fix_all_style_css('.') Or something like that.
> Because, yes, you're looping through directories but that's not what this
> function is used for, it's used for fixing files. Same for the function in
> the other file. The script filename would benefit from a rename too,
Hi Quentin,
Thank you very much for the review, I will apply all the changes based on your
review and send another patch.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56844): https://lists.yoctoproject.org/g/yocto/message/56844
Mute This Topic:
Signed-off-by: Abongwa Bonalais Amahnui
---
htmlscript.py | 36 +
stylescript.py | 61 ++
2 files changed, 97 insertions(+)
create mode 100644 htmlscript.py
create mode 100644 stylescript.py
diff --git
Signed-off-by: Abongwa Bonalais Amahnui
---
run-docs-build | 6 ++
1 file changed, 6 insertions(+)
diff --git a/run-docs-build b/run-docs-build
index db790dc..b6744ee 100755
--- a/run-docs-build
+++ b/run-docs-build
@@ -37,6 +37,12 @@ cd $outputdir
echo Extracing old content from archive
I sent a more recent patch which takes care of the topmost element overlapping
with the banner, puting it in a div called body and pushing it down so the
banner remains on top.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56799):
Signed-off-by: Abongwa Bonalais Amahnui
---
trial.py | 36 ++
trialstyle.py | 61 +++
2 files changed, 97 insertions(+)
create mode 100644 trial.py
create mode 100644 trialstyle.py
diff --git a/trial.py
On Sun, Apr 17, 2022 at 04:45 PM, Quentin Schulz wrote:
>
> import glob
> glob.glob('**/*.html', recursive=True)
Hi Quentin, thanks for the review.
If I use the glob module here, I will get rid of os.walk which was suggested by
Richard, and I have some issues implementing the glob as I am not
Signed-off-by: Abongwa Bonalais Amahnui
---
trial.py | 32 +++
trialstyle.py | 61 +++
2 files changed, 93 insertions(+)
create mode 100644 trial.py
create mode 100644 trialstyle.py
diff --git a/trial.py b/trial.py
I actually saw this licence on an spdx-tutorial repo on github but I will
change it in the next patch to MIT
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56789): https://lists.yoctoproject.org/g/yocto/message/56789
Mute This Topic:
Hi Richard, can I use a topic like " Added a banner on the old documentation
docs " as written in the bugzilla bug?
And I will also do some research how to implement the os.walk() module.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56788):
Signed-off-by: Abongwa Bonalais Amahnui
---
trial.py | 44 +++
trialstyle.py | 71 +++
2 files changed, 115 insertions(+)
create mode 100644 trial.py
create mode 100644 trialstyle.py
diff --git a/trial.py
Hi Richard,
I implemented the changes you gave and it successfully modified all the html
and css files.
But I noticed an issue, In the script to edit the css script, I discovered that
the class name of the tag in the html files are different for some files.
For such files, the banner will
The main issue I am facing now is how to go around the "UnicodeDecodeError:
'utf-8' codec can't decode byte 0xa0 in position 99: invalid start byte" for
the html script and the "UnicodeDecodeError: 'utf-8' codec can't decode byte
0xe9 in position 158: invalid continuation byte error" for the
The main issue I am facing now is how to go around the "UnicodeDecodeError:
'utf-8' codec can't decode byte 0xa0 in position 99: invalid start byte" for
the html script and the "UnicodeDecodeError: 'utf-8' codec can't decode byte
0xe9 in position 158: invalid continuation byte error" for the
Sorry for the filenames, trial.py contains the script that modifies the .html
files while trialstyle.py contains that for the .css files.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56781): https://lists.yoctoproject.org/g/yocto/message/56781
This is an RFC
missed putting that in the main patch.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#56780): https://lists.yoctoproject.org/g/yocto/message/56780
Mute This Topic: https://lists.yoctoproject.org/mt/90488259/21656
Group Owner:
The main issue I am facing now is how to go around the "UnicodeDecodeError:
'utf-8' codec can't decode byte 0xa0 in position 99: invalid start byte" for
the html script and the "UnicodeDecodeError: 'utf-8' codec can't decode byte
0xe9 in position 158: invalid continuation byte error" for the
41 matches
Mail list logo