Re: [yocto] [layerindex-web][PATCH 1/1] import_layer.py: add -t option for layer_type

2018-08-30 Thread Robert Yang
On 08/30/2018 02:20 PM, Paul Eggleton wrote: Hi Robert Sorry I meant to reply earlier. I'm not especially happy with moving the constants to utils.py. Is there any way we can avoid that? I will try to import models.py, but that may make things complicated. // Robert Thanks Paul On

Re: [yocto] [layerindex-web][PATCH 1/1] import_layer.py: add -t option for layer_type

2018-08-30 Thread Paul Eggleton
Hi Robert Sorry I meant to reply earlier. I'm not especially happy with moving the constants to utils.py. Is there any way we can avoid that? Thanks Paul On Thursday, 30 August 2018 2:05:11 PM NZST Robert Yang wrote: > Hi Paul, > > Do you have any comments on this, please ? > > // Robert >

Re: [yocto] [layerindex-web][PATCH 1/1] import_layer.py: add -t option for layer_type

2018-08-29 Thread Robert Yang
Hi Paul, Do you have any comments on this, please ? // Robert On 07/31/2018 03:57 PM, Robert Yang wrote: Hi Paul, On 07/24/2018 04:33 PM, Paul Eggleton wrote: Hi Robert, On Monday, 23 July 2018 12:30:01 PM CEST Robert Yang wrote: Now the logic is: Use options.layer_type if specified,

Re: [yocto] [layerindex-web][PATCH 1/1] import_layer.py: add -t option for layer_type

2018-07-31 Thread Robert Yang
Hi Paul, On 07/24/2018 04:33 PM, Paul Eggleton wrote: Hi Robert, On Monday, 23 July 2018 12:30:01 PM CEST Robert Yang wrote: Now the logic is: Use options.layer_type if specified, guess if not, default to 'M'. Note choices=['A', 'B', 'S', 'D', 'M', ''], the '' is for default='', we can't use

Re: [yocto] [layerindex-web][PATCH 1/1] import_layer.py: add -t option for layer_type

2018-07-26 Thread Paul Eggleton
Hi Robert, On Monday, 23 July 2018 12:30:01 PM CEST Robert Yang wrote: > Now the logic is: > Use options.layer_type if specified, guess if not, default to 'M'. > > Note choices=['A', 'B', 'S', 'D', 'M', ''], the '' is for default='', we can't > use default='M' here, otherwise we don't know

[yocto] [layerindex-web][PATCH 1/1] import_layer.py: add -t option for layer_type

2018-07-23 Thread Robert Yang
Now the logic is: Use options.layer_type if specified, guess if not, default to 'M'. Note choices=['A', 'B', 'S', 'D', 'M', ''], the '' is for default='', we can't use default='M' here, otherwise we don't know whether the 'M' is specified by user or not, we don't guess if it is specified by user,