Re: [yocto] Add extra parameters for qemu script

2010-12-14 Thread Scott Garman
On 12/13/2010 07:41 PM, Ke, Liping wrote: Hi, Scott I have updated the patch and tested with poky-tree mode (arm, x86). Since kvm and serial needs special processing, so for avoiding repeating the code, I will exclude serial and kvm in permitted extra-option, user need to use (serial, kvm) it

Re: [yocto] Add extra parameters for qemu script

2010-12-14 Thread Scott Garman
On 12/14/2010 02:27 PM, Scott Garman wrote: On 12/13/2010 07:41 PM, Ke, Liping wrote: Hi, Scott I have updated the patch and tested with poky-tree mode (arm, x86). Since kvm and serial needs special processing, so for avoiding repeating the code, I will exclude serial and kvm in permitted

Re: [yocto] Add extra parameters for qemu script

2010-12-14 Thread Ke, Liping
Hi, Scott Thanks for the review! Sure, I will use the script following distro-team conventions. And also, $MYNAME will be used in the final patch. And the debug line for building will be removed when I send the final patch. Thanks Regards, criping One final thing - when you resubmit your

Re: [yocto] Add extra parameters for qemu script

2010-12-13 Thread Ke, Liping
Hi, Scott I have updated the patch and tested with poky-tree mode (arm, x86). Since kvm and serial needs special processing, so for avoiding repeating the code, I will exclude serial and kvm in permitted extra-option, user need to use (serial, kvm) it they want to use it. For -m XXX options,

Re: [yocto] Add extra parameters for qemu script

2010-12-12 Thread Scott Garman
On 12/12/2010 05:43 PM, Ke, Liping wrote: I tend to feel that this approach is more flexible, and scales better than having to support each and every qemu option with our own script syntax. Is this acceptable, or should we continue to support our own custom options in addition to Criping's new

Re: [yocto] Add extra parameters for qemu script

2010-12-10 Thread Richard Purdie
On Thu, 2010-12-09 at 12:44 -0800, Garman, Scott A wrote: However, one thing I feel the need to run by Richard, as he expressed some preferences with how the poky-qemu script would work with regard to options. Richard: Criping's patch would remove the standalone options we had to the

[yocto] Add extra parameters for qemu script

2010-12-09 Thread Ke, Liping
Hi, Scott The patch is in the attachment for your review. Below is some notes: 1) Basically I wouldn't like to change any logic of the original code. 2) -serial stdio and -nographic options are removed since they're be covered by the extra parameters. 3) User input would be $poky-qemu qemux86

Re: [yocto] Add extra parameters for qemu script

2010-12-09 Thread Zhang, Jessica
Garman, Scott A wrote: On 12/09/2010 12:44 AM, Ke, Liping wrote: Hi, Scott The patch is in the attachment for your review. Below is some notes: 1) Basically I wouldn't like to change any logic of the original code. 2) -serial stdio and -nographic options are removed since they're be