My apologies for cross posting.
I have noticed some behavior I was not expecting with OE's Patchwork in
that it is hiding patches. I don't know if this is by design or a bug
in our Patchwork.
When a series of patches are submitted to the mailing list and are same
fix but against different
From: Andrew Donnellan
States with names containing special characters are not correctly escaped
when generating the select list. Use escape() to fix this.
Signed-off-by: Andrew Donnellan
(cherry picked from commit b3fa0c402e060622a5ed539a465d2fa98b1d2e13)
Signed-off-by: Daniel Axtens
[Fixup
This is an untested backported patch from stable/2.0 patchwork for the OE
version.
It is a function already being used in the file so I have high confidence it
wont introduce
any new issues.
Andrew Donnellan (1):
filters: Escape State names when generating selector HTML
Off Topic @: The same chaos as with German Govt. (KVR and Finanzamt).
Zoran
___
On Sun, May 12, 2019 at 8:05 PM akuster808 wrote:
>
> ok, so no Admins. This is unexceptionable.
>
> OE TSC and Board, I believe its your time to get involved.
>
> regards,
> Armin
>
> On 5/3/19 10:18 AM,
ok, so no Admins. This is unexceptionable.
OE TSC and Board, I believe its your time to get involved.
regards,
Armin
On 5/3/19 10:18 AM, akuster808 wrote:
> Hello OE folk,
>
> My apologies for cross posting.
>
> Who is the Admin for Patchwork?
>
> I would like additional privileges to manage
Hello OE folk,
My apologies for cross posting.
Who is the Admin for Patchwork?
I would like additional privileges to manage the "Yocto Project Layers"
queue.
Also, I would like additional privileges to add new branches for any
oe, meta-oe queues & yp layers.
kind regards,
Armin
--
From: Changqing Li
provide option of use like nginx + wsgi, this file is backported
from patchwork upstream https://github.com/getpatchwork/patchwork
Signed-off-by: Changqing Li
---
patchwork/wsgi.py | 30 ++
1 file changed, 30 insertions(+)
create mode 100644
Clicking on a patch name in Series view displays the patch at
the botton section in same page, but there is no easy way to
get a direct link to the patch, for example: to share the link.
This change includes the column "Link" where a direct link to the
patch is displayed and labeled with the
There is no visual indication on which is the active tab
at the Series data bar, providing a poor UX.
This change adds the "active" styling to the Series data bar.
[YOCTO #11886]
Signed-off-by: Jose Lamego
---
htdocs/js/series.js | 11 +--
1 file
Cover letter content section is displayed by default at the Series
view even if no cover letter is available, providing a poor UX.
This change makes the Cover letter content section to be displayed
by default if a cover letter is available, otherwise the Patches
list is to be displayed by default
Series view displays the "Revision" select element not in
line with the general patchwork style/design when viewed
using Firefox or Internet Explorer browsers due to a known
incompatibility of this browsers with Boostrap library
(for example, an arrow head inside a button is displayed next
to the
patches with different branch names included in their name are
wrongly appended as succesive revisions of the same patch in a
series. This is due to the patches being assigned to the same
series after their prefixes got removed during series naming/search.
This change looks for an updated release
Testing patch series' for appropriate integration and further
build against a branch requires several manual steps, providing
a poor code maintainer experience and increasing overall patch
integration workflow.
This change adds a script to automate the test-build process for
one or more patch
Testing patch series' for appropriate integration and further
build against a branch requires several manual steps, providing
a poor code maintainer experience and increasing overall patch
integration workflow.
This change adds a script to automate downloading one or more series
from patchwork,
The number/order prefix from a patch Subject line
is inapropriately included when naming a Series where
a cover letter is not provided and an additional
prefix is present at the Subject.
This change improves the substitution regex to omit
the number/order prefix but include any other prefix
that
The number/order prefix from a patch Subject line
is inapropriately included when naming a Series where
a cover letter is not provided and an additional
prefix is present at the Subject.
This change improves the substitution regex to omit
the number/order prefix but include any other prefix
that
The number/order prefix from a patch Subject line
is inapropriately included when naming a Series where
a cover letter is not provided and an additional
prefix is present at the Subject.
This change improves the substitution regex to omit
the number/order prefix but include any other prefix
that
The number/order prefix from a patch Subject line
is inapropriately included when naming a Series where
a cover letter is not provided and an additional
prefix is present at the Subject.
This change improves the substitution regex to omit
the number/order and any other prefix that may be
present.
The number/order prefix from a patch Subject line
is inapropriately included when naming a Series where
a cover letter is not provided and an additional
prefix is present at the Subject.
This change improves the substitution regex to omit
the number/order prefix but include any other prefix
that
Patch Series that are sent as replies to other Series with
different patch quantity are not appropriately detected as
such, breaking the thread and causing missing revisions.
This change improves the find_series_for_mail function to
appropriately detect when a message is part of a thread
by
The create-pull-request script creates patches as replies to a cover
letter, in the form of an email thread. If further revisions are sent to
the mailing list without referencing to the first revision, these new
revisions are not identified at the mailing list as part of the original
thread, but
PATCH prefix is not appropriately identified as such if it is not
sepparated from following word in an email Subject line. This leads to
wrong patch naming.
This change allows for appropriate patch naming by checking during
clean_subject function if "PATCH" prefix in Subject line is not
Patch Series that are sent as replies to other Series with
different patch quantity are not appropriately detected as
such, breaking the thread and causing missing revisions.
This change improves the find_series_for_mail function to
appropriately detect when a message is part of a thread
by
Patch Series that are sent as replies to other Series with
different patch quantity are not appropriately detected as
such, breaking the thread and causing missing revisions.
This change improves the find_series_for_mail function to
appropriately detect when a message is part of a thread
by
Patch status can be edited through email by project maintainers only
without any feedback if this is attempted by any other user,
providing a poor user experience.
This change extends the patch-status-through-email functionality
to be performed by the series submitter also, and provides a
paginator links do not include current "archive" status parameter,
which may lead to inaccurate data displayed in next views.
This change includes "archive" parameter from the paginator class
to all of the pagination links.
[YOCTO #11200]
Signed-off-by: Jose Lamego
patchwork pagination links do not keep "archive" filtering parameter,
which may lead to inaccurate data displayed in the next views.
These changes read the "archive" parameter from current GET request and add it
to the pagination links.
[YOCTO #11200]
Jose Lamego (2):
patchwork/paginator.py:
If a non-authenticated user tries to get a series view from
patchwork web UI, a 500 error message is displayed caused by
the database access attempted when filtering the bundle objects.
This change allows not-logged users to acces series view by
returning an empty bundle variable, instead of
This change calls the tablecheckbox.js plugin to add functionality
in a patch-list to allow user to select single / multiple / all
table row(s) by clicking.
[YOCTO #10819]
Signed-off-by: Jose Lamego
---
patchwork/templates/patchwork/patch-list.html | 2 ++
1 file
Selecting multiple items in a patch list must be done manually,
one item at a time, resulting in a poor user experience.
This change adds the jquery.tablecheckbox.js plugin that allows
to select single / multiple / all table row(s) by clicking.
[YOCTO #10819]
Signed-off-by: Jose Lamego
Selecting multiple patches in a range at the series view must be
performed on one-by-one basis, providing apoor user-experience.
This change allows to select patches in a range by clicking the
first patch, then shift-clicking the last patch in the desired range.
[YOCTO #10819]
Signed-off-by:
Selecting multiple items in a patch list must be done manually,
one item at a time, providing a poor user experience.
These changes add the jquery.tablecheckbox plugin and call it from
the patch-list tables to allow users to select single / multiple / all
table row(s) by clicking.
A function
This change adds patch and bundle edition forms, and patch selection
checkboxes.
[YOCTO #10822]
Signed-off-by: Jose Lamego
---
patchwork/templates/patchwork/series.html | 172 ++
1 file changed, 130 insertions(+), 42 deletions(-)
diff
This change adds control functions for individual and multiple
selection checkboxes.
[YOCTO #10822]
Signed-off-by: Jose Lamego
---
htdocs/js/series.js | 145
1 file changed, 125 insertions(+), 20 deletions(-)
This change adds patch and bundle edition actions to the series
view.
[YOCTO # 10822]
Signed-off-by: Jose Lamego
---
patchwork/views/series.py | 88 ---
1 file changed, 52 insertions(+), 36 deletions(-)
diff --git
Patches displayed at Series view must be individually opened to allow change
status or add them to a bundle, increasing needed time and providing a poor
user experience.
These changes add to Series view multiple select controls and the required
functionality for status change, bundle addition and
PATCH prefix is not appropriately identified as such if it is not
sepparated from following word in an email Subject line. This leads to
wrong email parsing and revisions not appended to initial series.
This change allows appropriate email parsing by checking if PATCH prefix
in Subject line is
Current email parsing filters-out messages with a message-id
that already exists in db, producing that some valid patch
revisions are not processed in patchwork.
This change allows for valid patches with duplicated message-id to be
processed by modifying the message-id in patchwork only when
These changes enable patch status updating, adding a patch to an existing
bundle and creating a new bundle from the series view.
[YOCTO #10973]
Changes in v2: Fixed javascript formatting and pep8 compliance.
Jose Lamego (2):
series.js: Get patch id and pass it to POST request
series.py: Add
Current series view is missing a POST call, avoiding users to update
or edit patch status or bundles.
This change adds POST call to series view, including the target
patch id, which is taken from request context.
[YOCTO #10973]
Signed-off-by: Jose Lamego
---
Patch forms in series view do not pass selected patch id
as request element during a POST call, so no status/bundle
updates can be performed from such view.
This change includes the selected patch id as a request
element and pass it to POST call through a hidden input field.
[YOCTO #10973]
From: Leonardo Sandoval
This new command allows to fetch bundles (set of selected patches by the user)
and print them into the stdout. For the moment, bundles must be public
(otherwise
these wont be found)
Command line example:
openembedded-core$
Current view is missing a POST call, avoiding users to update
or edit patch status or bundles.
This change adds POST call to series view, including the target
patch id, which is taken from request context.
[YOCTO #10973]
Signed-off-by: Jose Lamego
---
Patch forms in series view do not pass selected patch id
as context element during a POST call, so no status/bundle
updates can be performed from such view.
This change includes the selected patch id as a context
element and pass it to POST call through a hidden input field.
[YOCTO #10973]
This changes enable patch status updating, adding a patch to an existing
bundle and creating a new bundle from the series view.
[YOCTO #10973]
Jose Lamego (2):
series.js: Get patch id and pass it to POST request
series.py: Add POST call
htdocs/js/series.js | 24 --
Patch state can only be set/changed at patchwork web interface,
resulting in a poor user experience for project maintainers.
This change allows project maintainers to change a patch status
directly from an email message sent as a reply to the related mailing list
thread by including a the string
Hi all,
As some of you are aware some of my colleagues and I have been working on
improving how incoming patches are handled - initially for OE-Core but we hope
to arrive at something that will be useful for other layers as well. The aim
was to do so without adversely affecting existing
From: Jose Lamego
Patchwork may incorrectly identify emails containing patch-like content or
that are replies/forwards from a previous message as patches, thus wrongly
creating a new series revision.
This change makes "[PATCH" prefix in subject mandatory for emails to be
On 01/09/2017 04:49 AM, Patrick Ohly wrote:
>...
>
> I'm wondering if we can address two bugs with the same fix, something
> that requires that the Subject line is starting with a set of tags plus
> the [PATCH] tag. For example:
>
> patch_prefix = re.match('(\s*\[[^]]*\]\s*)*\[\s*PATCH',
n a series,
>>>>> without leaving the series view.
>>>>>
>>>>
>>>> The patch looks fine to me. Are you also posting these to upstream
>>>> patchwork ?
>>>
>>> Thanks for the review Khem. These changes currently are g
es allows viewing content from each patch in a series,
>>>> without leaving the series view.
>>>>
>>>
>>> The patch looks fine to me. Are you also posting these to upstream
>>> patchwork ?
>>
>> Thanks for the review Khem. These cha
he series view.
>>>
>>
>> The patch looks fine to me. Are you also posting these to upstream patchwork
>> ?
>
> Thanks for the review Khem. These changes currently are going only to
> the Yocto-Patchwork repository [1]. Upstream [2] has been not-maintained
> f
er navigation buttons, providing a poor UX.
>>
>> This changes allows viewing content from each patch in a series,
>> without leaving the series view.
>>
>
> The patch looks fine to me. Are you also posting these to upstream patchwork ?
Thanks for the review Khem. The
On Fri, Jan 6, 2017 at 6:50 AM, Jose Lamego
wrote:
> From: Jose Lamego
>
> Reviewing patches from a series requires heavy usage of the
> browser navigation buttons, providing a poor UX.
>
> This changes allows viewing content from each
On Fri, 2017-01-06 at 17:03 -0600, Jose Lamego wrote:
> Patchwork may incorrectly identify emails containing patch-like content as
> patches.
> This change makes "[PATCH" prefix in subject mandatory for emails to be
> considered as new patches.
>
> [YOCTO #10764]
>
> Signed-off-by: Jose Lamego
Patchwork may incorrectly identify emails containing patch-like content as
patches.
This change makes "[PATCH" prefix in subject mandatory for emails to be
considered as new patches.
[YOCTO #10764]
Signed-off-by: Jose Lamego
---
patchwork/bin/parsemail.py | 3 ++-
From: Jose Lamego
Reviewing patches from a series requires heavy usage of the
browser navigation buttons, providing a poor UX.
This changes allows viewing content from each patch in a series,
without leaving the series view.
[YOCTO #10627]
Signed-off-by: Jose Lamego
On 12/05/2016 02:30 AM, Patrick Ohly wrote:
> On Fri, 2016-12-02 at 14:29 -0600, Jose Lamego wrote:
>> Patch Series created without a cover letter are named using a
>> non-descriptive generic string.
>>
>> This change names the series using either the first 30 characters in
>> patch #1 plus the
On Fri, 2016-12-02 at 14:29 -0600, Jose Lamego wrote:
> Patch Series created without a cover letter are named using a
> non-descriptive generic string.
>
> This change names the series using either the first 30 characters in
> patch #1 plus the remaining patches number, or the patch name for
>
Patch Series created without a cover letter are named using a
non-descriptive generic string.
This change names the series using either the first 30 characters in
patch #1 plus the remaining patches number, or the patch name for
one-patch (1/1) series.
[YOCTO #10625]
Signed-off-by: Jose Lamego
Patch Series created without a cover letter are named using a
non-descriptive generic string.
This change names the series using either the first 30 characters in
patch #1 plus the remaining patches number, or the patch name for
one-patch (1/1) series.
[YOCTO #10625]
Signed-off-by: Jose Lamego
Patch Series created without a cover letter are named using a
non-descriptive generic string.
This change names the series using either the first 30 characters in
patch #1 plus the remaining patches number, or the patch name for
one-patch (1/1) series.
[Yocto #10625]
Signed-off-by: Jose Lamego
g list for
contributions and reviews.
+
+
+Where to Send Patches
+=
+
+Patchwork patches must be sent to the Yocto Project mailing list including the
"[patchwork]" prefix in the message subject, for example:
[yocto][patchwork][patch 1/2] file.txt: change description
+
+Git
Patch Series created without a cover letter are named using a
non-descriptive generic string.
This change names the series using the first 30 characters in
patch #1 and the remaining patches number.
[Yocto #10625]
Signed-off-by: Jose Lamego
---
Some patch messages containinig pull-request information
are being skipped due to formatting variations.
This change improves the pull-request search to include those
small variants.
Signed-off-by: Jose Lamego
---
patchwork/bin/parsemail.py | 4 ++--
1 file
References list for previous emails only include first found
header, causing that some root messages for series are skipped
and corresponding series revision numbering gets corrupted.
This change forces references list to use last header found,
allowing for Patch emails created with
These changes are to improve the way email-chain references are created
and pull-request information to be included even with small formatting
variations.
Jose Lamego (2):
patchwork.bin.parsemail: Use oldest header references
patchwork.bin.parsemail: Improve pull-request regex
After 2 weeks of testing and some performance tuning we are going to
proceed with the Patchwork upgrade. Data entered into the current
version in the next few hours may need to be re-entered after the upgrade.
All features of the current Patchwork install work in the new version.
So while there
On Mon, Jun 20, 2016 at 10:47:16AM -0700, Michael Halstead wrote:
> Hello,
>
> OpenEmbedded is nearly ready to upgrade to a new version of Patchwork.
> The new version offers several new features that will allow OpenEmbedded
> to improve developer workflow and automated checks on incoming
On 06/20/2016 10:47 AM, Michael Halstead wrote:
> Hello,
>
> OpenEmbedded is nearly ready to upgrade to a new version of Patchwork.
> The new version offers several new features that will allow OpenEmbedded
> to improve developer workflow and automated checks on incoming patches.
>
> If you
Hello,
OpenEmbedded is nearly ready to upgrade to a new version of Patchwork.
The new version offers several new features that will allow OpenEmbedded
to improve developer workflow and automated checks on incoming patches.
If you are a Patchwork user please visit
71 matches
Mail list logo