Re: [Yum-devel] [PATCH 2/2] When installing for obsoletes, see if newer pkg is in trans. (BZ 516577)

2009-08-17 Thread James Antill
On Mon, 2009-08-17 at 16:52 -0400, Seth Vidal wrote: > > On Mon, 17 Aug 2009, James Antill wrote: > > > Otherwise we install two different versions, if the newer pkg doesn't > > also do the obsoletes (stupid, stupid, packaging). > > okay this makes me angry. > > This is a packaging bug. Simple,

Re: [Yum-devel] [PATCH 2/2] When installing for obsoletes, see if newer pkg is in trans. (BZ 516577)

2009-08-17 Thread Seth Vidal
On Mon, 17 Aug 2009, James Antill wrote: Otherwise we install two different versions, if the newer pkg doesn't also do the obsoletes (stupid, stupid, packaging). okay this makes me angry. This is a packaging bug. Simple, Nothing else. Why are we fixing this packaging bug? I can even see

[Yum-devel] [PATCH 1/2] Add testcases for quagga, BZ 516577

2009-08-17 Thread James Antill
--- test/simpleobsoletestests.py | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/test/simpleobsoletestests.py b/test/simpleobsoletestests.py index cf1821f..3c7e2b0 100644 --- a/test/simpleobsoletestests.py +++ b/test/simpleobsoletestests.

[Yum-devel] [PATCH 2/2] When installing for obsoletes, see if newer pkg is in trans. (BZ 516577)

2009-08-17 Thread James Antill
Otherwise we install two different versions, if the newer pkg doesn't also do the obsoletes (stupid, stupid, packaging). --- yum/__init__.py|9 + yum/transactioninfo.py | 11 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/yum/__init__.py b/yum/__

Re: [Yum-devel] [PATCH 1/1] Add simplePkglist() (and dep. patches)

2009-08-17 Thread Seth Vidal
On Mon, 17 Aug 2009, James Antill wrote: I split the patches out so it'd be easier to see the different bits (most of which is just moving stuff around so we can reuse it). But here's the full thing: thanks for the complete patch - for whatever reason it made it easier for me track between

Re: [Yum-devel] [PATCH 1/1] Add simplePkglist() (and dep. patches)

2009-08-17 Thread James Antill
I split the patches out so it'd be easier to see the different bits (most of which is just moving stuff around so we can reuse it). But here's the full thing: diff --git a/yum/sqlitesack.py b/yum/sqlitesack.py index 643f1f6..f4d3f95 100644 --- a/yum/sqlitesack.py +++ b/yum/sqlitesack.py @@ -725,

[Yum-devel] [PATCH 5/5] Add optimized simplePkgList() to sqlitesack, significant speedup:

2009-08-17 Thread James Antill
This is what the above few patches were for, as this function now just calls them. Speed differences on my machine: time (echo | yum update wodim) Before: 8.0 seconds After: 6.5 seconds (81.25%) time yum check-update Before: 3.9 seconds After: 2.5 seconds (64.10%) --- yum/sqlitesack.py

[Yum-devel] [PATCH 1/5] Split the setup part of _buildPkgObjList() into a separate function

2009-08-17 Thread James Antill
--- yum/sqlitesack.py | 24 +--- 1 files changed, 17 insertions(+), 7 deletions(-) diff --git a/yum/sqlitesack.py b/yum/sqlitesack.py index 643f1f6..277ca8c 100644 --- a/yum/sqlitesack.py +++ b/yum/sqlitesack.py @@ -1434,16 +1434,13 @@ class YumSqlitePackageSack(yumRepo.YumP

[Yum-devel] [PATCH 2/5] Split the SQL part of _buildPkgObjList() into a separate function

2009-08-17 Thread James Antill
--- yum/sqlitesack.py | 27 +-- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/yum/sqlitesack.py b/yum/sqlitesack.py index 277ca8c..843cf81 100644 --- a/yum/sqlitesack.py +++ b/yum/sqlitesack.py @@ -1473,16 +1473,9 @@ class YumSqlitePackageSack(yumRepo.Y

[Yum-devel] [PATCH 3/5] Fix whitespace, comments and doc-comments

2009-08-17 Thread James Antill
--- yum/sqlitesack.py | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/yum/sqlitesack.py b/yum/sqlitesack.py index 843cf81..4d8ac0a 100644 --- a/yum/sqlitesack.py +++ b/yum/sqlitesack.py @@ -1496,14 +1496,12 @@ class YumSqlitePackageSack(yumRepo.YumPackage

[Yum-devel] [PATCH 4/5] Add pkgtupByKeyData, so we don't have to create package objects

2009-08-17 Thread James Antill
--- yum/sqlitesack.py | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/yum/sqlitesack.py b/yum/sqlitesack.py index 4d8ac0a..1edf2ab 100644 --- a/yum/sqlitesack.py +++ b/yum/sqlitesack.py @@ -725,6 +725,19 @@ class YumSqlitePackageSack(yumRepo.YumPackageSack):