Re: [Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Seth Vidal
On Wed, 16 Sep 2009, Tim Lauridsen wrote: On 09/16/2009 06:09 PM, Tim Lauridsen wrote: On 09/16/2009 05:47 PM, Seth Vidal wrote: I was thinking something like: for txmbr in self.tsInfo.getMembersWithState(None, [TS_UPDATED, TS_OBSOLETED]): does that make sense? -sv Yes , for txm

Re: [Yum-devel] [PATCH] add doUtilTransaction() method to YumUtilBase.

2009-09-16 Thread Tim Lauridsen
On 09/16/2009 06:44 PM, Seth Vidal wrote: This method handles a bunch of the exit cases we deal with coming out of doTransaction() so we don't have to write the same exception catching code over and over again. This will be tied into some yum-utils updates, too. --- utils.py | 65

Re: [Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Tim Lauridsen
On 09/16/2009 06:09 PM, Tim Lauridsen wrote: On 09/16/2009 05:47 PM, Seth Vidal wrote: I was thinking something like: for txmbr in self.tsInfo.getMembersWithState(None, [TS_UPDATED, TS_OBSOLETED]): does that make sense? -sv Yes , for txmbr in self.tsInfo.getMembersWithState(None, [T

[Yum-devel] [PATCH] add doUtilTransaction() method to YumUtilBase.

2009-09-16 Thread Seth Vidal
This method handles a bunch of the exit cases we deal with coming out of doTransaction() so we don't have to write the same exception catching code over and over again. This will be tied into some yum-utils updates, too. --- utils.py | 65 +

Re: [Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Tim Lauridsen
On 09/16/2009 05:47 PM, Seth Vidal wrote: I was thinking something like: for txmbr in self.tsInfo.getMembersWithState(None, [TS_UPDATED, TS_OBSOLETED]): does that make sense? -sv Yes , for txmbr in self.tsInfo.getMembersWithState(None, [TS_UPDATED]): looks good to me, i will clean i

Re: [Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Seth Vidal
On Wed, 16 Sep 2009, Tim Lauridsen wrote: On 09/16/2009 04:20 PM, Seth Vidal wrote: Do you have to iterate across all the pkgs in the ts to do that? Couldn't you reduce the set you're going across to only pkgs which are going to be updated or obsoleted? What about this change ? diff --git

Re: [Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Tim Lauridsen
On 09/16/2009 04:20 PM, Seth Vidal wrote: Do you have to iterate across all the pkgs in the ts to do that? Couldn't you reduce the set you're going across to only pkgs which are going to be updated or obsoleted? What about this change ? diff --git a/yum/__init__.py b/yum/__init__.py index c8f

Re: [Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Seth Vidal
On Wed, 16 Sep 2009, Tim Lauridsen wrote: Make skip broken handle cases where pkg dupes are installed and an update updates both of them but has dep problems. Make sure we get all the TS_UPDATED members cleaned from the transaction. https://bugzilla.redhat.com/show_bug.cgi?id=522112 The patc

[Yum-devel] [PATCH] make skipbroken handle multiple TS_UPDATED members

2009-09-16 Thread Tim Lauridsen
Make skip broken handle cases where pkg dupes are installed and an update updates both of them but has dep problems. Make sure we get all the TS_UPDATED members cleaned from the transaction. https://bugzilla.redhat.com/show_bug.cgi?id=522112 The patch contains a testcase to show the issues and t