Re: [Yum-devel] [PATCH] - don't include requirements in the metadata when the pkg provides it for itself.

2009-10-28 Thread Tim Lauridsen
On 10/28/2009 04:30 PM, Seth Vidal wrote: --- yum/packages.py |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index 71430fd..d9baa59 100644 --- a/yum/packages.py +++ b/yum/packages.py @@ -998,6 +998,15 @@ class YumAvailablePack

Re: [Yum-devel] [PATCH] Fix: Unicode unequal comparison failed to convert both arguments to Unicode

2009-10-28 Thread Seth Vidal
On Wed, 28 Oct 2009, James Antill wrote: --- yum/packages.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index 709e73e..6941373 100644 --- a/yum/packages.py +++ b/yum/packages.py @@ -410,7 +410,10 @@ class RpmBase(object):

Re: [Yum-devel] [PATCH] A couple of minor opts for depsolving, in checkInstall and checkRemove

2009-10-28 Thread Seth Vidal
On Wed, 28 Oct 2009, James Antill wrote: checkInstall: Don't filter out requires that we provide, as it's done at createrepo time now. checkRemove: If we have a req. we don't provide, check the things that update/obsolete us for it first. Why should we be removing this check? 1. lots of

Re: [Yum-devel] [PATCH] Minor opt. for allowedMultipleInstalls() and pkg.*_names callers

2009-10-28 Thread Seth Vidal
On Wed, 28 Oct 2009, James Antill wrote: --- yum/depsolve.py | 11 ++- yum/packages.py |9 - 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/yum/depsolve.py b/yum/depsolve.py index e5b3a42..4d3d5ca 100644 --- a/yum/depsolve.py +++ b/yum/depsolve.py @@ -188

[Yum-devel] [PATCH] Fix: Unicode unequal comparison failed to convert both arguments to Unicode

2009-10-28 Thread James Antill
--- yum/packages.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index 709e73e..6941373 100644 --- a/yum/packages.py +++ b/yum/packages.py @@ -410,7 +410,10 @@ class RpmBase(object): # find the named entry in pkgobj, do the

[Yum-devel] [PATCH] A couple of minor opts for depsolving, in checkInstall and checkRemove

2009-10-28 Thread James Antill
checkInstall: Don't filter out requires that we provide, as it's done at createrepo time now. checkRemove: If we have a req. we don't provide, check the things that update/obsolete us for it first. --- yum/depsolve.py | 22 +- 1 files changed, 17 insertions(+), 5 deletions

[Yum-devel] [PATCH] Minor opt. for allowedMultipleInstalls() and pkg.*_names callers

2009-10-28 Thread James Antill
--- yum/depsolve.py | 11 ++- yum/packages.py |9 - 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/yum/depsolve.py b/yum/depsolve.py index e5b3a42..4d3d5ca 100644 --- a/yum/depsolve.py +++ b/yum/depsolve.py @@ -188,13 +188,14 @@ class Depsolve(object):

Re: [Yum-devel] [PATCH 2/2] Simplify re_full_search_needed "primary" regex.

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 23:20 +0200, Ville Skyttä wrote: > --- > yum/misc.py |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) ACK both. Did you try: re.compile('([-.*?]|\[.+\]).').search ? ___ Yum-devel mailing list Yum-devel@lists.baseur

[Yum-devel] [PATCH 1/2] Cache regex match/search function instead of the regex for a small speedup.

2009-10-28 Thread Ville Skyttä
--- yum/misc.py | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/yum/misc.py b/yum/misc.py index 26bbaba..a689b16 100644 --- a/yum/misc.py +++ b/yum/misc.py @@ -78,8 +78,8 @@ def re_glob(s): """ Tests if a string is a shell wildcard. """ global _re_

[Yum-devel] [PATCH 2/2] Simplify re_full_search_needed "primary" regex.

2009-10-28 Thread Ville Skyttä
--- yum/misc.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/yum/misc.py b/yum/misc.py index a689b16..3e86d08 100644 --- a/yum/misc.py +++ b/yum/misc.py @@ -115,8 +115,8 @@ def re_full_search_needed(s): """ Tests if a string needs a full nevra match, instead of

Re: [Yum-devel] [PATCH 2/3] Treat square brackets same way in re_full_search_needed and refineSearchPattern as in re_glob.

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 21:49 +0200, Ville Skyttä wrote: > I _think_ the final "." before the "$" does have some value, so instead of > replacing it with ".*" it could be replaced with ".". If a search string has > only one of these matching chars/constructs and it is at end of the string > (thi

Re: [Yum-devel] [PATCH 2/3] Treat square brackets same way in re_full_search_needed and refineSearchPattern as in re_glob.

2009-10-28 Thread Ville Skyttä
On Wednesday 28 October 2009, James Antill wrote: > On Wed, 2009-10-28 at 21:10 +0200, Ville Skyttä wrote: > > --- > > yum/misc.py |4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > ACK but... > > > diff --git a/yum/misc.py b/yum/misc.py > > index 78f296c..26bbaba 100644 > >

Re: [Yum-devel] [PATCH 2/3] Treat square brackets same way in re_full_search_needed and refineSearchPattern as in re_glob.

2009-10-28 Thread Ville Skyttä
On Wednesday 28 October 2009, Ville Skyttä wrote: > @@ -115,7 +115,7 @@ def re_full_search_needed(s): [...] > -one = re.compile('.*[-.*?[\]].*.$') > +one = re.compile('.*([-.*?]|\[.+\]).*.$') About this one: what's the intention of the ".*.$" at the end? It's unrelated to th

Re: [Yum-devel] [PATCH 2/3] Treat square brackets same way in re_full_search_needed and refineSearchPattern as in re_glob.

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 21:10 +0200, Ville Skyttä wrote: > --- > yum/misc.py |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) ACK but... > diff --git a/yum/misc.py b/yum/misc.py > index 78f296c..26bbaba 100644 > --- a/yum/misc.py > +++ b/yum/misc.py > @@ -115,7 +115,7 @@ def re_ful

[Yum-devel] [PATCH 2/3] Treat square brackets same way in re_full_search_needed and refineSearchPattern as in re_glob.

2009-10-28 Thread Ville Skyttä
--- yum/misc.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/yum/misc.py b/yum/misc.py index 78f296c..26bbaba 100644 --- a/yum/misc.py +++ b/yum/misc.py @@ -115,7 +115,7 @@ def re_full_search_needed(s): """ Tests if a string needs a full nevra match, instead of

Re: [Yum-devel] [PATCH 1/3] Simplify some regexps.

2009-10-28 Thread Ville Skyttä
On Wednesday 28 October 2009, James Antill wrote: > On Wed, 2009-10-28 at 19:06 +0200, Ville Skyttä wrote: > > --- > > yum/misc.py|8 > > yum/yumRepo.py |4 ++-- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > Does removing the ^ from the regexp make any difference?

Re: [Yum-devel] [PATCH 1/3] Simplify some regexps.

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 19:06 +0200, Ville Skyttä wrote: > --- > yum/misc.py|8 > yum/yumRepo.py |4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) Does removing the ^ from the regexp make any difference? Coming from a perl/grep background I always expect that they ar

[Yum-devel] [PATCH 1/3] Simplify some regexps.

2009-10-28 Thread Ville Skyttä
--- yum/misc.py|8 yum/yumRepo.py |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/yum/misc.py b/yum/misc.py index de195c6..78f296c 100644 --- a/yum/misc.py +++ b/yum/misc.py @@ -87,7 +87,7 @@ def re_filename(s): classes wrong (are they supporte

Re: [Yum-devel] show-leaves and "RPMDB has been altered" warnings

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 17:40 +0200, Ville Skyttä wrote: > On Wednesday 28 October 2009, James Antill wrote: > > On Tue, 2009-10-27 at 22:27 +0200, Ville Skyttä wrote: > > > Hello, > > > > > > With the show-leaves plugin enabled, every yum transaction prints a > > > "RPMDB has been altered since the

Re: [Yum-devel] [PATCH] Add utf8* calls for history and real i18n, add to_unicode(name) everywhere

2009-10-28 Thread Seth Vidal
ACK On Tue, 27 Oct 2009, James Antill wrote: --- output.py | 60 ++-- 1 files changed, 46 insertions(+), 14 deletions(-) diff --git a/output.py b/output.py index 9635473..d5713fd 100755 --- a/output.py +++ b/output.py @@ -1195,7 +1195,1

Re: [Yum-devel] [PATCH 2/2] also remove filerequires if we have the file

2009-10-28 Thread Seth Vidal
On Wed, 28 Oct 2009, James Antill wrote: On Wed, 2009-10-28 at 11:32 -0400, Seth Vidal wrote: --- yum/packages.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index d9baa59..891bd6d 100644 --- a/yum/packages.py +++ b/yum/packages

Re: [Yum-devel] [PATCH 2/2] also remove filerequires if we have the file

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 11:32 -0400, Seth Vidal wrote: > --- > yum/packages.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/yum/packages.py b/yum/packages.py > index d9baa59..891bd6d 100644 > --- a/yum/packages.py > +++ b/yum/packages.py > @@ -999,7 +999,7 @@ class

Re: [Yum-devel] show-leaves and "RPMDB has been altered" warnings

2009-10-28 Thread Ville Skyttä
On Wednesday 28 October 2009, James Antill wrote: > On Tue, 2009-10-27 at 22:27 +0200, Ville Skyttä wrote: > > Hello, > > > > With the show-leaves plugin enabled, every yum transaction prints a > > "RPMDB has been altered since the last yum transaction" warning. So I > > suppose conduit.getRpmDB()

[Yum-devel] [PATCH 2/2] also remove filerequires if we have the file

2009-10-28 Thread Seth Vidal
--- yum/packages.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index d9baa59..891bd6d 100644 --- a/yum/packages.py +++ b/yum/packages.py @@ -999,7 +999,7 @@ class YumAvailablePackage(PackageObject, RpmBase): if name.star

[Yum-devel] [PATCH 1/2] - don't include requirements in the metadata when the pkg provides it for itself.

2009-10-28 Thread Seth Vidal
--- yum/packages.py |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index 71430fd..d9baa59 100644 --- a/yum/packages.py +++ b/yum/packages.py @@ -998,6 +998,15 @@ class YumAvailablePackage(PackageObject, RpmBase): for (nam

[Yum-devel] [PATCH] - don't include requirements in the metadata when the pkg provides it for itself.

2009-10-28 Thread Seth Vidal
--- yum/packages.py |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index 71430fd..d9baa59 100644 --- a/yum/packages.py +++ b/yum/packages.py @@ -998,6 +998,15 @@ class YumAvailablePackage(PackageObject, RpmBase): for (nam

Re: [Yum-devel] yum api kernel install weirdness

2009-10-28 Thread James Antill
On Wed, 2009-10-28 at 08:45 +0100, Tim Lauridsen wrote: > > > On Wed, Oct 28, 2009 at 7:32 AM, Tim Lauridsen > wrote: > > Now it gets really weird. > > sudo yum update kernel is working > > but sudo ./yummain.py update kernel fails > >

Re: [Yum-devel] yum api kernel install weirdness

2009-10-28 Thread Tim Lauridsen
On Wed, Oct 28, 2009 at 7:32 AM, Tim Lauridsen wrote: > > Now it gets really weird. > > sudo yum update kernel is working > > but sudo ./yummain.py update kernel fails > > [...@hoth yum]$ sudo ./yummain.py update kernel > > it is an selinux issue :( setenforce 0 sudo python test.py works. Tim