Re: [Yum-devel] [PATCH 3/9] Add rpmdb problems, and cmdline to the history DBv2 update

2010-05-07 Thread James Antill
On Fri, 2010-05-07 at 18:41 +0200, Tim Lauridsen wrote: > > +packages = property(fget=lambda self: > self._getProbPkgs()) > > Any reason for we use the syntax all over yum, instead of > > @property > def packages(self): > return self._getProbPkgs() > > much more rea

Re: [Yum-devel] [PATCH] Show which repos. were cleaned, in yum clean XYZ

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 4:52 PM, James Antill wrote: > --- > cli.py | 29 ++--- > yum/__init__.py | 28 > 2 files changed, 34 insertions(+), 23 deletions(-) > > diff --git a/cli.py b/cli.py > index fc91de2..a075fa0 100644 > --- a/c

Re: [Yum-devel] [PATCH 8/9] Fix sorting of historic rpmdb problems

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:12 PM, James Antill wrote: > --- > yum/history.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/yum/history.py b/yum/history.py > index bd10e51..8983261 100644 > --- a/yum/history.py > +++ b/yum/history.py > @@ -131,7 +131,7 @@ class YumH

Re: [Yum-devel] [PATCH 9/9] Save, and then Highlight, the "main" package which has a problem

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:12 PM, James Antill wrote: > --- > output.py | 12 +--- > yum/history.py | 15 +++ > 2 files changed, 20 insertions(+), 7 deletions(-) > > diff --git a/output.py b/output.py > index 484fd5e..7a3cfb0 100755 > --- a/output.py > +++ b/output.py

Re: [Yum-devel] [PATCH 7/9] Mark pre-exsting rpmdb problems in history list, with 'P'.

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:12 PM, James Antill wrote: > --- > docs/yum.8 |2 ++ > output.py |2 ++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/docs/yum.8 b/docs/yum.8 > index f9eb7fd..053173d 100644 > --- a/docs/yum.8 > +++ b/docs/yum.8 > @@ -320,6 +320,8 @@ if the

Re: [Yum-devel] [PATCH 6/9] Move obsoleted.obsoleter check into the correct problem loop

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:12 PM, James Antill wrote: > --- > yum/__init__.py |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/yum/__init__.py b/yum/__init__.py > index ca1bff0..dbc1be8 100644 > --- a/yum/__init__.py > +++ b/yum/__init__.py > @@ -1229,14 +1229,14 @@

Re: [Yum-devel] [PATCH 5/9] Output cmdline and rpmdb problems in history info

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:11 PM, James Antill wrote: > --- > output.py | 46 +++--- > 1 files changed, 31 insertions(+), 15 deletions(-) > > diff --git a/output.py b/output.py > index 65d3f44..188c52a 100755 > --- a/output.py > +++ b/output.py > @@ -1438,

Re: [Yum-devel] [PATCH 4/9] Save rpmdb problems, and cmdline, into yum history

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:11 PM, James Antill wrote: > --- > yum/__init__.py | 14 +- > 1 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/yum/__init__.py b/yum/__init__.py > index 57c92f3..ca1bff0 100644 > --- a/yum/__init__.py > +++ b/yum/__init__.py > @@ -1243,7 +1

Re: [Yum-devel] [PATCH 3/9] Add rpmdb problems, and cmdline to the history DBv2 update

2010-05-07 Thread Tim Lauridsen
> +packages = property(fget=lambda self: self._getProbPkgs()) > Any reason for we use the syntax all over yum, instead of @property def packages(self): return self._getProbPkgs() much more readable in my world :) ACK ___ Yum-devel mailing

Re: [Yum-devel] [PATCH 2/9] Add three views to make look at history by hand easier

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:11 PM, James Antill wrote: > --- > yum/history.py | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/yum/history.py b/yum/history.py > index 7305a62..358edf1 100644 > --- a/yum/history.py > +++ b/yum/history.py > @@ -65

Re: [Yum-devel] [PATCH 1/9] Add skip broken packages to history transaction.

2010-05-07 Thread Tim Lauridsen
On Thu, May 6, 2010 at 9:11 PM, James Antill wrote: > --- > docs/yum.8 |2 + > output.py | 24 +- > yum/__init__.py |4 ++- > yum/history.py | 70 > ++- > 4 files changed, 96 insertions(+), 4 deletions(-)