Re: [Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

2010-06-14 Thread seth vidal
On Mon, 2010-06-14 at 19:54 +0300, Panu Matilainen wrote: > IMO if something relies on the current compareEVR() behavior wrt 0 vs None > epoch then it's about time we fix that something instead. The issue is > getting a bit long in the tooth, 8 years and still it keeps popping up > every now and

Re: [Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

2010-06-14 Thread Panu Matilainen
On Mon, 14 Jun 2010, seth vidal wrote: On Mon, 2010-06-14 at 19:26 +0300, Panu Matilainen wrote: Well, current compareEVR() behavior in the first case is just plain wrong. Maybe this doesn't come up in yum/repomd context, but if somebody uses compareEVR() as a convenience wrapper (which it bas

Re: [Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

2010-06-14 Thread seth vidal
On Mon, 2010-06-14 at 19:26 +0300, Panu Matilainen wrote: > Well, current compareEVR() behavior in the first case is just plain wrong. > Maybe this doesn't come up in yum/repomd context, but if somebody uses > compareEVR() as a convenience wrapper (which it basically is) over > labelCompare() w

Re: [Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

2010-06-14 Thread Panu Matilainen
On Mon, 14 Jun 2010, seth vidal wrote: On Sun, 2010-06-13 at 18:45 +0300, Ville Skyttä wrote: On Saturday 05 June 2010, Jon Stanley wrote: > On Sat, Jun 5, 2010 at 1:49 PM, Jon Stanley wrote: > > Actually come to think of it this was against the RPM API, but the > > same holds true, I think -

Re: [Yum-devel] small bugfix

2010-06-14 Thread BebiX kost
Of course not. str(problem) will never work (because problem has unicode symbols). If you want to encode problem to str you just do problem.encode('utf-8'), but why would you need that? Everything works with just fine with unicode(problem). p.s.: Oh, I forgot that you could just rewrite the __s

Re: [Yum-devel] [PATCH] Deal with putting non-en rpmdb problems in the history DB

2010-06-14 Thread Tim Lauridsen
On Mon, Jun 14, 2010 at 5:50 PM, James Antill wrote: > --- > yum/history.py |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/yum/history.py b/yum/history.py > index bfb0b45..a676773 100644 > --- a/yum/history.py > +++ b/yum/history.py > @@ -414,7 +414,8 @@ class Yu

Re: [Yum-devel] small bugfix

2010-06-14 Thread James Antill
On Mon, 2010-06-14 at 16:06 +0300, BebiX kost wrote: > Hi! There's a small bug at yum right now (fedora rawhide) for non-ascii users > and here's how to fix it: > at /usr/lib/python2.6/site-packages/yum/history.py at line 417 replace str to > unicode. > > Something like this: > > def _trans_rpm

Re: [Yum-devel] [PATCH] Deal with putting non-en rpmdb problems in the history DB

2010-06-14 Thread seth vidal
On Mon, 2010-06-14 at 11:50 -0400, James Antill wrote: > --- > yum/history.py |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/yum/history.py b/yum/history.py > index bfb0b45..a676773 100644 > --- a/yum/history.py > +++ b/yum/history.py > @@ -414,7 +414,8 @@ class Y

[Yum-devel] [PATCH] Deal with putting non-en rpmdb problems in the history DB

2010-06-14 Thread James Antill
--- yum/history.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/yum/history.py b/yum/history.py index bfb0b45..a676773 100644 --- a/yum/history.py +++ b/yum/history.py @@ -414,7 +414,8 @@ class YumHistory: """INSERT INTO trans_rpmdb_problems

[Yum-devel] small bugfix

2010-06-14 Thread BebiX kost
Hi! There's a small bug at yum right now (fedora rawhide) for non-ascii users and here's how to fix it: at /usr/lib/python2.6/site-packages/yum/history.py at line 417 replace str to unicode. Something like this: def _trans_rpmdb_problem(self, problem): if not hasattr(self, '_tid'): return # Not

Re: [Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

2010-06-14 Thread seth vidal
On Sun, 2010-06-13 at 18:45 +0300, Ville Skyttä wrote: > On Saturday 05 June 2010, Jon Stanley wrote: > > On Sat, Jun 5, 2010 at 1:49 PM, Jon Stanley wrote: > > > Actually come to think of it this was against the RPM API, but the > > > same holds true, I think - it's up to the developer to do some

Re: [Yum-devel] [yum-commits] repoquery.py

2010-06-14 Thread seth vidal
On Mon, 2010-06-14 at 06:05 +, James Antill wrote: > repoquery.py |5 + > 1 file changed, 5 insertions(+) > > New commits: > commit 3ada4634e16dcd1c1899ed4b98fdbc76b9d4f710 > Author: James Antill > Date: Mon Jun 14 02:05:26 2010 -0400 > > Add reponame variable, as we can't use