On 02/24/2011 07:04 PM, seth vidal wrote:
On Thu, 2011-02-24 at 11:18 +0200, Panu Matilainen wrote:
We really only want the txmbr in the key, everything else can be
reached through it. This avoids copying any data around as txmbrs
reside in memory anyway, so the key is just a cheap reference
to what we already have. With the new key ->  txmbr helper in the
callback, this is truly trivial to handle there.

Additionally, enable this new mode for yum itself.

P.S. The "self.txmbrCallback" name is horrible. Better ideas wanted...

ack

self.use_txmbr_in_callback = True

it's longer but it is clearer and it's not like it is used all over the
place.

Yeah, that's a whole lot better, thanks :)

The whole lot pushed now, with the dict -> set changed and one previously missed h -> name variable name in the callback in repackage case fixed (it wouldn't have made a difference in that case but makes the idea more obvious).

        - Panu -
_______________________________________________
Yum-devel mailing list
Yum-devel@lists.baseurl.org
http://lists.baseurl.org/mailman/listinfo/yum-devel

Reply via email to