[Yum-devel] [PATCH 3/3] Uses ngettext to pluralise messages produced in __init__.py. BZ 552317

2011-06-20 Thread Nick Jacek
--- yum/__init__.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/yum/__init__.py b/yum/__init__.py index 8fa957f..aa66890 100644 --- a/yum/__init__.py +++ b/yum/__init__.py @@ -2262,7 +2262,7 @@ class YumBase(depsolve.Depsolve): self.verbose_logger.l

[Yum-devel] [PATCH 2/3] Uses ngettext to pluralise messages produced by several functions in cli.py. BZ 552317

2011-06-20 Thread Nick Jacek
--- cli.py | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/cli.py b/cli.py index 5c3b9c3..82f286f 100644 --- a/cli.py +++ b/cli.py @@ -38,7 +38,7 @@ import yum.logginglevels import yum.misc import yum.plugins from rpmUtils.arch import isMultiL

[Yum-devel] [PATCH 1/3] Changes the Transaction Summary so that the plurals are printed using ngettext. BZ 552317

2011-06-20 Thread Nick Jacek
--- output.py | 42 ++ 1 files changed, 26 insertions(+), 16 deletions(-) diff --git a/output.py b/output.py index 3840f82..b8f757e 100755 --- a/output.py +++ b/output.py @@ -38,7 +38,7 @@ import yum.misc from rpmUtils.miscutils import checkSignals, form

Re: [Yum-devel] [patch] leaking yum.log fd when instantiating multiple YumBase objects

2011-06-20 Thread James Antill
On Mon, 2011-06-20 at 05:24 -0400, Zdenek Pavlas wrote: > Hi, > > >> -def setFileLog(uid, logfile): > >> +def setFileLog(uid, logfile, cleanup=[]): > > > This is also a python gotcha: > > http://stackoverflow.com/questions/2170684/python-init-argument-problem > > Thanks for pointing this out! W

Re: [Yum-devel] [patch] leaking yum.log fd when instantiating multiple YumBase objects

2011-06-20 Thread Zdenek Pavlas
Hi, >> -def setFileLog(uid, logfile): >> +def setFileLog(uid, logfile, cleanup=[]): > This is also a python gotcha: > http://stackoverflow.com/questions/2170684/python-init-argument-problem Thanks for pointing this out! We very likely have only one call site and that sets the argument explicit