Re: [Yum-devel] [PATCH] honor proxy=_none_ again. BZ 814224

2012-04-19 Thread Zdenek Pavlas
> ACK. AIUI setting proxy to '' now means that this disables the proxy > support for older urlgrabber (using curl) versions too, or no? I'd say so. The old urlgrabber code is: if opts.proxies: (yes, dict is non-empty) for (scheme, proxy) in opts.proxies.items():

Re: [Yum-devel] [PATCH] honor proxy=_none_ again. BZ 814224

2012-04-19 Thread James Antill
On Thu, 2012-04-19 at 17:26 +0200, Zdeněk Pavlas wrote: > After commit b804e8d4fc88d proxy=_none_ evaluates to None (option not set). > Change the default so we can tell it apart. Pass _none_ as '' to urlgrabber. ACK. AIUI setting proxy to '' now means that this disables the proxy support for ol

Re: [Yum-devel] [PATCH] use proxy='' to disable default proxies

2012-04-19 Thread James Antill
On Thu, 2012-04-19 at 17:25 +0200, Zdeněk Pavlas wrote: > Instead of ignoring proxy settings '_none_' or '', > use it to disable default proxies in libcurl. Yeh, this seems fine too. ACK. ___ Yum-devel mailing list Yum-devel@lists.baseurl.org http://li

[Yum-devel] [PATCH] honor proxy=_none_ again. BZ 814224

2012-04-19 Thread Zdeněk Pavlas
After commit b804e8d4fc88d proxy=_none_ evaluates to None (option not set). Change the default so we can tell it apart. Pass _none_ as '' to urlgrabber. --- yum/config.py |2 +- yum/yumRepo.py |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/yum/config.py b/yum/con

[Yum-devel] [PATCH] use proxy='' to disable default proxies

2012-04-19 Thread Zdeněk Pavlas
Instead of ignoring proxy settings '_none_' or '', use it to disable default proxies in libcurl. --- urlgrabber/grabber.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/urlgrabber/grabber.py b/urlgrabber/grabber.py index c334242..38ae1f7 100644 --- a/urlgrabber/gra

Re: [Yum-devel] [PATCH] honor proxy=_none_ again. BZ 814224

2012-04-19 Thread James Antill
On Thu, 2012-04-19 at 15:23 +0200, Zdeněk Pavlas wrote: > After commit b804e8d4fc88d _none_ evaluates to None (option not set). > We should keep it as-is instead, because it was used to explicitly > disable default proxies (set in ENV). Premature ACKing. Sorry. > --- > yum/config.py |2 +-

Re: [Yum-devel] [PATCH] honor proxy=_none_ again. BZ 814224

2012-04-19 Thread James Antill
On Thu, 2012-04-19 at 15:23 +0200, Zdeněk Pavlas wrote: > After commit b804e8d4fc88d _none_ evaluates to None (option not set). > We should keep it as-is instead, because it was used to explicitly > disable default proxies (set in ENV). ACK. ___ Yum-de

Re: [Yum-devel] [PATCH] 'proxy=_none_' should disable default proxies

2012-04-19 Thread James Antill
On Thu, 2012-04-19 at 15:12 +0200, Zdeněk Pavlas wrote: > libcurl uses default proxies. to disable that, we have to set > it explicitly to ''. '_none_' was once used for this purpose > so make it work again. This patch overrides the previous one, right? ACK. signature.asc Description: This i

[Yum-devel] [PATCH] honor proxy=_none_ again. BZ 814224

2012-04-19 Thread Zdeněk Pavlas
After commit b804e8d4fc88d _none_ evaluates to None (option not set). We should keep it as-is instead, because it was used to explicitly disable default proxies (set in ENV). --- yum/config.py |2 +- yum/yumRepo.py |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/yum/

[Yum-devel] [PATCH] 'proxy=_none_' should disable default proxies

2012-04-19 Thread Zdeněk Pavlas
libcurl uses default proxies. to disable that, we have to set it explicitly to ''. '_none_' was once used for this purpose so make it work again. --- urlgrabber/grabber.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/urlgrabber/grabber.py b/urlgrabber/grabber.py

[Yum-devel] [PATCH] Allow user to disable default proxies. BZ 814224.

2012-04-19 Thread Zdeněk Pavlas
libcurl uses $http_proxy et al by default. The only way to disable this is setting proxy to "". --- urlgrabber/grabber.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/urlgrabber/grabber.py b/urlgrabber/grabber.py index f89b5d7..cedd865 100644 --- a/urlgrabber/grabber.