Re: [Yum-devel] [PATCH] No implicit use of TextMultiFileMeter

2012-08-21 Thread James Antill
On Tue, 2012-08-21 at 05:28 -0400, Zdenek Pavlas wrote: > > Can we call this multi_progress_obj instead? > > ok > > > > -def parallel_wait(meter = 'text'): > > > +def parallel_wait(): > > > > Any caller that does parallel_wait('text') or > > parallel_wait(meter='text') gets a traceback after t

Re: [Yum-devel] [PATCH] No implicit use of TextMultiFileMeter

2012-08-21 Thread Zdenek Pavlas
> Can we call this multi_progress_obj instead? ok > > -def parallel_wait(meter = 'text'): > > +def parallel_wait(): > > Any caller that does parallel_wait('text') or > parallel_wait(meter='text') gets a traceback after this change. No user (AFAIK) has ever used that arg, and since now we have

Re: [Yum-devel] [PATCH] Use TextMultiFileMeter as multi_obj

2012-08-21 Thread Zdenek Pavlas
> This seems fine, although when I tried putting multifile logic just > inside yum all I seemed to need to do is call newMeter() before the > grab (no urlgrabber changes). I see, you did most of the work outside of the urlgrabber, including multi.start(), and creating the multi-helper objects for