Re: [Yum-devel] [PATCH] Show full URLs and mirror errors when _getFile() fails.

2012-08-22 Thread Zdenek Pavlas
> One fix, which I think is compatible, would be: > value = property(...) I like it better, too. Works fine in my test setup, no need to touch exception2msg(). # Have our own custom .value with all the mirror errors. class NoMoreMirrorsRepoError(RepoError): def __init__(self, value=None

Re: [Yum-devel] [PATCH] Show full URLs and mirror errors when _getFile() fails.

2012-08-22 Thread James Antill
On Wed, 2012-08-22 at 11:50 +0200, Zdeněk Pavlas wrote: > - add .errors attribute to NoMoreMirrorsRepoError. > - include URLs and error messages in unicode(e). > - exception2msg: prefer unicode(e) to e.value. > diff --git a/yum/Errors.py b/yum/Errors.py > index c1af4ad..ca23c24 100644 > --- a/yum/

Re: [Yum-devel] [PATCH] Show full URLs and mirror errors when _getFile() fails.

2012-08-22 Thread James Antill
On Wed, 2012-08-22 at 11:50 +0200, Zdeněk Pavlas wrote: > - exception2msg: prefer unicode(e) to e.value. > diff --git a/yum/i18n.py b/yum/i18n.py > index 76a258d..c4f72eb 100755 > --- a/yum/i18n.py > +++ b/yum/i18n.py > @@ -474,12 +474,12 @@ def exception2msg(e): > # to_unicode(e.value); unic

[Yum-devel] [PATCH] Set .errors attribute on exceptions from MirrorGroup failures.

2012-08-22 Thread Zdeněk Pavlas
--- urlgrabber/grabber.py | 10 +++--- urlgrabber/mirror.py | 24 +--- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/urlgrabber/grabber.py b/urlgrabber/grabber.py index 87d8b59..ffd5a10 100644 --- a/urlgrabber/grabber.py +++ b/urlgrabber/grabber.py @

[Yum-devel] [PATCH] Show full URLs and mirror errors when _getFile() fails.

2012-08-22 Thread Zdeněk Pavlas
- add .errors attribute to NoMoreMirrorsRepoError. - include URLs and error messages in unicode(e). - exception2msg: prefer unicode(e) to e.value. Also updated/fixed: - We may never get URLGrabError(256) without MirrorGroup. - When MG's failure_callback signals fail=1, the LAST error is re-rai

Re: [Yum-devel] [PATCH] No implicit use of TextMultiFileMeter

2012-08-22 Thread Zdenek Pavlas
> We don't necessarily need to honor it, as I think it'll mostly DTRT > anyway ... but having a call traceback because we removed the API is > bad. So just set it to default to None and ignore it. > Apart from the API break, ACK. Yeah, a dummy arg does not hurt.. pushed.

Re: [Yum-devel] [PATCH] Fix a typo in checkfunc. BZ 850550

2012-08-22 Thread tim.laurid...@gmail.com
On Wed, Aug 22, 2012 at 9:56 AM, Zdeněk Pavlas wrote: > --- > yum/yumRepo.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/yum/yumRepo.py b/yum/yumRepo.py > index 3792087..e60fc20 100644 > --- a/yum/yumRepo.py > +++ b/yum/yumRepo.py > @@ -926,7 +926,7 @@ Insuffic

[Yum-devel] [PATCH] Fix a typo in checkfunc. BZ 850550

2012-08-22 Thread Zdeněk Pavlas
--- yum/yumRepo.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/yum/yumRepo.py b/yum/yumRepo.py index 3792087..e60fc20 100644 --- a/yum/yumRepo.py +++ b/yum/yumRepo.py @@ -926,7 +926,7 @@ Insufficient space in download directory %s misc.unlink_f(local)