Re: [Yum-devel] [PATCH 2/2] call getCanonArch() only once

2013-03-14 Thread James Antill
On Thu, 2013-03-14 at 12:29 +0100, Zdenek Pavlas wrote: > --- > rpmUtils/arch.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK. ___ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel

Re: [Yum-devel] [PATCH 1/2] speed up /proc/cpuinfo parsing on i585 and i686

2013-03-14 Thread James Antill
On Thu, 2013-03-14 at 12:29 +0100, Zdenek Pavlas wrote: > With 8 cores, /proc/cpuinfo is 240 lines, > but we need just the first hit (cpu#0) Is this measurable? I'm slightly worried about some edge case on someones machine with different CPUs in different sockets, but meh. it was probably broken

Re: [Yum-devel] [PATCH 1/2] speed up /proc/cpuinfo parsing on i585 and i686

2013-03-14 Thread Aleš Kozumplík
On 03/14/2013 12:29 PM, Zdenek Pavlas wrote: With 8 cores, /proc/cpuinfo is 240 lines, but we need just the first hit (cpu#0) But with eight cores you also parse /proc/cpuinfo eight times faster! Other than that it looks good to me. Ales ___ Yum-dev

[Yum-devel] [PATCH 2/2] call getCanonArch() only once

2013-03-14 Thread Zdenek Pavlas
--- rpmUtils/arch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rpmUtils/arch.py b/rpmUtils/arch.py index 10b4331..57cbdfc 100644 --- a/rpmUtils/arch.py +++ b/rpmUtils/arch.py @@ -471,7 +471,7 @@ class ArchStorage(object): if arch: self.canonarch = ar

[Yum-devel] [PATCH 1/2] speed up /proc/cpuinfo parsing on i585 and i686

2013-03-14 Thread Zdenek Pavlas
With 8 cores, /proc/cpuinfo is 240 lines, but we need just the first hit (cpu#0) --- rpmUtils/arch.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/rpmUtils/arch.py b/rpmUtils/arch.py index d560be0..10b4331 100644 --- a/rpmUtils/arch.py +++ b/rpmUtils/arch.py