Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Panu Matilainen
On 04/26/2013 08:15 AM, Panu Matilainen wrote: On 04/25/2013 08:53 PM, James Antill wrote: On Thu, 2013-04-25 at 19:32 +0300, Panu Matilainen wrote: On 04/25/2013 06:02 PM, James Antill wrote: On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote: Something in commit fc395ef14b135b35914888

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Panu Matilainen
On 04/25/2013 08:53 PM, James Antill wrote: On Thu, 2013-04-25 at 19:32 +0300, Panu Matilainen wrote: On 04/25/2013 06:02 PM, James Antill wrote: On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote: Something in commit fc395ef14b135b3591488816ec902057fd8d03f4 makes diskspacecheck=0 not di

Re: [Yum-devel] [PATCH] debuginfo-install: handle YumBaseError

2013-04-25 Thread James Antill
On Thu, 2013-04-25 at 11:38 -0400, Zdenek Pavlas wrote: > > What triggers this that isn't caught by the stuff in YumUtilBase? Can > > we change it so it is caught by something in there? > > --enablerepo foo calls getRepo(foo), and this raises Errors.RepoError > when there's no such repo. Yum cat

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread James Antill
On Thu, 2013-04-25 at 19:32 +0300, Panu Matilainen wrote: > On 04/25/2013 06:02 PM, James Antill wrote: > > On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote: > >> Something in commit fc395ef14b135b3591488816ec902057fd8d03f4 makes > >> diskspacecheck=0 not disable the disk space check at all

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Panu Matilainen
On 04/25/2013 06:02 PM, James Antill wrote: On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote: Something in commit fc395ef14b135b3591488816ec902057fd8d03f4 makes diskspacecheck=0 not disable the disk space check at all. Moving the thing to initActionTs() where other similar initialization

Re: [Yum-devel] [PATCH] debuginfo-install: handle YumBaseError

2013-04-25 Thread Zdenek Pavlas
> What triggers this that isn't caught by the stuff in YumUtilBase? Can > we change it so it is caught by something in there? --enablerepo foo calls getRepo(foo), and this raises Errors.RepoError when there's no such repo. Yum catches this in yummain.py > If we need to keep this don't we need

Re: [Yum-devel] [PATCH] debuginfo-install: handle YumBaseError

2013-04-25 Thread James Antill
On Thu, 2013-04-25 at 15:01 +0200, Zdenek Pavlas wrote: > --- > debuginfo-install.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) What triggers this that isn't caught by the stuff in YumUtilBase? Can we change it so it is caught by something in there? If we need to keep this don

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread James Antill
On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote: > Something in commit fc395ef14b135b3591488816ec902057fd8d03f4 makes > diskspacecheck=0 not disable the disk space check at all. Moving > the thing to initActionTs() where other similar initialization > is done makes it work again. In additi

[Yum-devel] [PATCH] debuginfo-install: handle YumBaseError

2013-04-25 Thread Zdenek Pavlas
--- debuginfo-install.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/debuginfo-install.py b/debuginfo-install.py index 5c1f77d..be2ff2d 100755 --- a/debuginfo-install.py +++ b/debuginfo-install.py @@ -53,7 +53,11 @@ class DebugInfoInstall(YumUtilBase):

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Zdenek Pavlas
> $ python -c "print(False == 0)" > True Uh, got me. Thanks! I was not aware of this. >>> isinstance(False, int) True ___ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Ville Skyttä
On 2013-04-25 11:17, Zdenek Pavlas wrote: > This code is dead, as diskspacecheck is a BoolOption. > It's True/False, but never == 0. Surely better to just test the boolean value, but isn't False in practice always == 0? $ python -c "print(False == 0)" True $ python3 -c "print(False == 0)" True

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Panu Matilainen
On 04/25/2013 11:17 AM, Zdenek Pavlas wrote: --- a/rpmUtils/transaction.py +++ b/rpmUtils/transaction.py @@ -114,7 +114,7 @@ class TransactionWrapper: # FIXME GARBAGE - remove once this is reimplemented elsehwere # KEEPING FOR API COMPLIANCE ONLY if conf.get('diskspa

Re: [Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

2013-04-25 Thread Zdenek Pavlas
> --- a/rpmUtils/transaction.py > +++ b/rpmUtils/transaction.py > @@ -114,7 +114,7 @@ class TransactionWrapper: > # FIXME GARBAGE - remove once this is reimplemented elsehwere > # KEEPING FOR API COMPLIANCE ONLY > if conf.get('diskspacecheck') == 0: > -self.ts