Re: [Yum-devel] [yum-utils] package-graph

2011-03-10 Thread James Antill
On Thu, 2011-03-10 at 08:33 +0100, Pierre-Yves Chibon wrote: > > Attached is the patch. Pushed. ___ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel

Re: [Yum-devel] [yum-utils] package-graph

2011-03-09 Thread Pierre-Yves Chibon
On Mon, 2011-03-07 at 10:16 +0100, Pierre-Yves Chibon wrote: > > The man page (docs/repoquery.1) has not been updated with the new > > arguments. > > I will fix this > > > The patch adds some Dot() calls, but I don't see Dot() defined > > anywhere. > > Indeed, they should be DotPlot(). > > Sin

Re: [Yum-devel] [yum-utils] package-graph

2011-03-07 Thread Pierre-Yves Chibon
On Fri, 2011-02-25 at 00:22 +0200, Ville Skyttä wrote: > > 0001-Update-arguments.patch > > Sorry for chiming in this late, but here's a few remarks about this > patch: > > The man page (docs/repoquery.1) has not been updated with the new > arguments. I will fix this > The patch adds some Dot() c

Re: [Yum-devel] [yum-utils] package-graph

2011-02-24 Thread Ville Skyttä
> 0001-Update-arguments.patch Sorry for chiming in this late, but here's a few remarks about this patch: The man page (docs/repoquery.1) has not been updated with the new arguments. The patch adds some Dot() calls, but I don't see Dot() defined anywhere. _

Re: [Yum-devel] [yum-utils] package-graph

2011-01-22 Thread Pierre-Yves
On Fri, 2011-01-21 at 16:21 -0500, James Antill wrote: > > > > 2. There are three places where this happens: > > > > > > +if dot is None: > > > +self._tree_print_req(pkg, req, level) > > > +lim = level > > > +else: > > > +dot.addPackage(pkg, rpk

Re: [Yum-devel] [yum-utils] package-graph

2011-01-21 Thread James Antill
On Fri, 2011-01-21 at 17:33 +0100, Pierre-Yves wrote: > On Fri, 2011-01-21 at 09:36 -0500, James Antill wrote: > > > > ...so we don't have the indentation change? > > I tried to fix this. Looks good. > > 2. There are three places where this happens: > > > > +if dot is None: > > +

Re: [Yum-devel] [yum-utils] package-graph

2011-01-21 Thread Pierre-Yves
On Fri, 2011-01-21 at 09:36 -0500, James Antill wrote: > > ...so we don't have the indentation change? I tried to fix this. > > 2. There are three places where this happens: > > +if dot is None: > +self._tree_print_req(pkg, req, level) > +lim = level > +

Re: [Yum-devel] [yum-utils] package-graph

2011-01-21 Thread James Antill
On Thu, 2011-01-20 at 22:45 +0100, Pierre-Yves wrote: > On Mon, 2011-01-17 at 09:25 -0500, James Antill wrote: > > > > 1. default_header should be inside the DotPlot class. > > > > 2. The big == 'ascii-tree' tests should be merged a lot more, as most > > of the code is the same. Just using dot=No

Re: [Yum-devel] [yum-utils] package-graph

2011-01-20 Thread Pierre-Yves
On Mon, 2011-01-17 at 09:25 -0500, James Antill wrote: > > 1. default_header should be inside the DotPlot class. > > 2. The big == 'ascii-tree' tests should be merged a lot more, as most > of the code is the same. Just using dot=None, and still passing > dot=dot in the ascii-tree branch should be

Re: [Yum-devel] [yum-utils] package-graph

2011-01-17 Thread James Antill
On Sat, 2011-01-15 at 14:03 +0100, Pierre-Yves wrote: > On Wed, 2011-01-12 at 11:15 -0500, seth vidal wrote: > > > > --requires --level=# --output=ascii-tree|dot-tree > > There is a patch which works for > --requires --level=[#|all] --output=[text|ascii-tree|dot-tree] > and > --whatrequires --le

Re: [Yum-devel] [yum-utils] package-graph

2011-01-15 Thread Pierre-Yves
On Wed, 2011-01-12 at 11:15 -0500, seth vidal wrote: > > --requires --level=# --output=ascii-tree|dot-tree There is a patch which works for --requires --level=[#|all] --output=[text|ascii-tree|dot-tree] and --whatrequires --level=[#|all] --output=[text|ascii-tree|dot-tree] (the old --tree-requi

Re: [Yum-devel] [yum-utils] package-graph

2011-01-12 Thread Pierre-Yves
On Wed, 2011-01-12 at 11:15 -0500, seth vidal wrote: > > > > Why are these both shown in the output? Just one of them should > be > > > visible > > > > (and the other one deprecated but kept around for compatibilitys > > > sake): > > > >--show-duplicates show all versions of packages > > >

Re: [Yum-devel] [yum-utils] package-graph

2011-01-12 Thread seth vidal
On Tue, 2011-01-11 at 21:28 +0100, Pierre-Yves wrote: > On Fri, 2011-01-07 at 15:46 +0100, Pierre-Yves wrote: > > On Thu, Dec 23, 2010 at 02:07:34PM +0200, Panu Matilainen wrote: > > > > > > Why are these both shown in the output? Just one of them should be > > visible > > > (and the other one de

Re: [Yum-devel] [yum-utils] package-graph

2011-01-11 Thread Pierre-Yves
On Fri, 2011-01-07 at 15:46 +0100, Pierre-Yves wrote: > On Thu, Dec 23, 2010 at 02:07:34PM +0200, Panu Matilainen wrote: > > > > Why are these both shown in the output? Just one of them should be > visible > > (and the other one deprecated but kept around for compatibilitys > sake): > >--show

Re: [Yum-devel] [yum-utils] package-graph

2011-01-07 Thread Pierre-Yves
On Thu, Dec 23, 2010 at 02:07:34PM +0200, Panu Matilainen wrote: > > Why are these both shown in the output? Just one of them should be visible > (and the other one deprecated but kept around for compatibilitys sake): >--show-duplicates show all versions of packages >--show-dupes

Re: [Yum-devel] [yum-utils] package-graph

2010-12-23 Thread Panu Matilainen
On Wed, 22 Dec 2010, seth vidal wrote: On Sun, 2010-12-19 at 00:54 +0100, Pierre-Yves wrote: On Sat, 2010-12-18 at 19:09 +0200, Panu Matilainen wrote: How about just adding a dot output mode to repoquery? Something like --tree-format=[tree|dot] and defaulting tree (feel free to pick a better n

Re: [Yum-devel] [yum-utils] package-graph

2010-12-22 Thread seth vidal
On Sun, 2010-12-19 at 00:54 +0100, Pierre-Yves wrote: > On Sat, 2010-12-18 at 19:09 +0200, Panu Matilainen wrote: > > How about just adding a dot output mode to repoquery? Something like > > --tree-format=[tree|dot] and defaulting tree (feel free to pick a > > better name though :) > > I'd go mor

Re: [Yum-devel] [yum-utils] package-graph

2010-12-18 Thread Pierre-Yves
On Sat, 2010-12-18 at 19:09 +0200, Panu Matilainen wrote: > How about just adding a dot output mode to repoquery? Something like > --tree-format=[tree|dot] and defaulting tree (feel free to pick a > better name though :) I'd go more for --tree-format=[asci|dot] ;-) > The dot formatting in packa

Re: [Yum-devel] [yum-utils] package-graph

2010-12-18 Thread Panu Matilainen
On Sat, 18 Dec 2010, Pierre-Yves wrote: On Fri, 2010-12-17 at 18:59 +0100, Pierre-Yves wrote: The file can be found there: http://pingou.fedorapeople.org/package-graph.py Actually this version fails if tested from /usr/bin as it can not import the class from repoquery. Should I look to port t

Re: [Yum-devel] [yum-utils] package-graph

2010-12-18 Thread Pierre-Yves
On Fri, 2010-12-17 at 18:59 +0100, Pierre-Yves wrote: > The file can be found there: > http://pingou.fedorapeople.org/package-graph.py Actually this version fails if tested from /usr/bin as it can not import the class from repoquery. Should I look to port the code from repoquery to a dedicated py

[Yum-devel] [yum-utils] package-graph

2010-12-17 Thread Pierre-Yves
Hi, I would like to propose the following addition to the yum-utils package. It is a small script largely inspired from the repo-graph and the repoquery which generates a dot file for the command --tree-requires and --tree-whatrequires (at the moment). I tried to keep the same structure as in repo