Forget to mention that the version of the patch I've reviewd is "RFC v2"
Marwan
___
zathura mailing list
zathura@lists.pwmt.org
http://lists.pwmt.org/mailman/listinfo/zathura
Hi Benoît,
Sorry for being late on this.
On Fri, Mar 22, 2013 at 11:02:57AM +0100, Benoît Knecht wrote:
> Hi Marwan,
>
> Marwan Tanager wrote:
> > This patch eliminates the aforementioned problems by setting the adjustment
> > ratio dynamically from the 'value-changed' callback only if the vert
Instead of guesstimating the values of the scrollbars adjustments after
a change in zoom level, connect callbacks to the "changed" GtkAdjustment
event (which is emitted when the bounds or page_size of the adjustment
change, e.g. when the zoom level changes), and compute the new values
from there.
Instead of guesstimating the values of the scrollbars adjustments after
a change in zoom level, connect callbacks to the "changed" GtkAdjustment
event (which is emitted when the bounds or page_size of the adjustment
change, e.g. when the zoom level changes), and compute the new values
from there.
Hi Marwan,
Marwan Tanager wrote:
> This patch eliminates the aforementioned problems by setting the adjustment
> ratio dynamically from the 'value-changed' callback only if the vertical
> adjustment upper bound hasn't changed. If it's found to be changed, this
> means
> that the document scale
