Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi, On 2013-08-23 14:29:39, Abdó Roig-Maranges wrote: > > I've attached two screenshots of zathura 0.2.4 running with girara 0.1.6 > > and girara 0.1.7 plus the patch. With girara 0.1.6 there is a lot more > > padding around the text in the statusbar and it's readable (maybe the > > status bar is

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi, > I've attached two screenshots of zathura 0.2.4 running with girara 0.1.6 > and girara 0.1.7 plus the patch. With girara 0.1.6 there is a lot more > padding around the text in the statusbar and it's readable (maybe the > status bar is just too small in 0.1.7 and it's not the padding after >

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

On 2013-08-22 14:15:55, Abdó Roig-Maranges wrote: > > Oops, sorry about that... > > > > One of the bugs caused by the changes is http://bugs.pwmt.org/issue338. > > I attach a patch fixing the :info thing. A bit of a hack remains to set the > statusbar height the same as the inputbar (session.c

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Oops, sorry about that... > One of the bugs caused by the changes is http://bugs.pwmt.org/issue338. I attach a patch fixing the :info thing. A bit of a hack remains to set the statusbar height the same as the inputbar (session.c lines 284-291). Do you know of a better solution? The notification

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi, maybe it was a bit to early to merge this changes. The statusbar now doesn't work correctly anymore in GTK2. One of the bugs caused by the changes is http://bugs.pwmt.org/issue338. Also, the padding doesn't look right. Could you maybe take a look at that? Regards -- Sebastian Ramacher _

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi > I think that once we get the GTK3 stuff working properly [1], we should just > get rid of the GTK2 support. ok > Oh, yeah, that's an ABI break. Do we need the new members anywhere outside of > girara? If not, I'd say we introduce a girara_session_private_s struct and add > a pointer to it

[zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi again, I've done some changes on girara statusbar, inputbar and friends. It all started because on GTK3, notification and inputbar had different heights. I attach a patch with three commits: 1. reorganize widgets from statusbar inputbar and friends. Just put them all under a common c