[Zeitgeist] [Bug 579972] Re: Send events to zeitgeist

2010-05-14 Thread François Ingelrest
Thanks for the patch, I just discovered what Zeigeist is :-) I'll try to play with it to make sure everything works correctly with this plugin. ** Changed in: decibel-audio-player Status: New = Confirmed ** Changed in: decibel-audio-player Assignee: (unassigned) = François Ingelrest

[Zeitgeist] [Bug 580364] [NEW] searching with subject_storage in template is not working

2010-05-14 Thread Markus Korn
Public bug reported: I've just added a testcase to lp:zeitgeist which shows that a template like template = Event.new_for_values(subject_storage=) returns all events, instead of only all events with subject_storage=. There are two ways to fx this bug: 1.) implement searching for

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/negation_support into lp:zeitgeist

2010-05-14 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/negation_support into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #485966 Using filters (text match / exclusion / etc) https://bugs.launchpad.net/bugs/485966 This branch adds negation support

[Zeitgeist] [Bug 580372] [NEW] Event.new_for_values() does not chec arguments

2010-05-14 Thread Markus Korn
Public bug reported: Something like event = Event.new_for_values(boo=234234) should raise a TypeError (or ValueError) instead of creating an Event which make no sense: print event Event([['', '1273824118015', '', '', ''], [], '']) ** Affects: zeitgeist Importance: Undecided

[Zeitgeist] [Bug 580364] Re: searching with subject_storage in template is not working

2010-05-14 Thread Mikkel Kamstrup Erlandsen
I think that we want to support this at some point. Maybe we should just throw an exception for now and then target the feature for 0.3.5 (ie /not/ for 0.3.4) -- searching with subject_storage in template is not working https://bugs.launchpad.net/bugs/580364 You received this bug notification

Re: [Zeitgeist] [Merge] lp:~thekorn/zeitgeist/negation_support into lp:zeitgeist

2010-05-14 Thread Mikkel Kamstrup Erlandsen
Review: Approve review only, no test run It looks very good Markus! And lots of unit tests +10 for that ;-) One thing - nothing critical: * Why not make EQUAL a real function instead of a lambda? I am not sure of the Python internals, but I'd assume that functions are cheaper because they

[Zeitgeist] [Bug 579972] Re: Send events to zeitgeist

2010-05-14 Thread Mikkel Kamstrup Erlandsen
Jendrik: Interpretation.AUDIO is future proof. MUSIC will be removed in ZG 0.3.4. The actual metadata of the track (such as it's album) are better stored in an actual metadata repository - such as Tracker (which probably already knows this). Zeitgeist is mainly meant as a log to store the event

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/negation_support into lp:zeitgeist

2010-05-14 Thread noreply
The proposal to merge lp:~thekorn/zeitgeist/negation_support into lp:zeitgeist has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~thekorn/zeitgeist/negation_support/+merge/25299 Your team Zeitgeist Framework Team is requested to review the proposed merge of

[Zeitgeist] [Bug 580364] Re: searching with subject_storage in template is not working

2010-05-14 Thread Markus Korn
Ok, zeitgeist is not raising a ValueError if someone tries to query on storage, I'll let this bug open so we can implement support for this field in the future. revno: 1471 committer: Markus Korn thek...@gmx.de branch nick: trunk

[Zeitgeist] [Bug 580372] Re: Event.new_for_values() does not check arguments

2010-05-14 Thread Markus Korn
** Summary changed: - Event.new_for_values() does not chec arguments + Event.new_for_values() does not check arguments -- Event.new_for_values() does not check arguments https://bugs.launchpad.net/bugs/580372 You received this bug notification because you are a member of Zeitgeist Framework

[Zeitgeist] [Bug 485966] Re: Using filters (text match / exclusion / etc)

2010-05-14 Thread Markus Korn
I've started working on the wildcard part in lp:~thekorn/zeitgeist/wildcard_support And I'm adding another constraint: searches are case sensitive. Please cry out loud if you think that case sensitive searches is a bad thing. -- Using filters (text match / exclusion / etc)

[Zeitgeist] [Bug 487321] Re: What value should subject.origin have?

2010-05-14 Thread Michal Hruby
I think that it makes sense to store in subject.origin the location where subject.uri can be found. Therefore the web page visit events could have as origin set either their referrer page or the domain (only if referrer is unavailable, since we can parse the domain from uri anyway). As for

[Zeitgeist] [Bug 580601] [NEW] Inconsistent data in event_view

2010-05-14 Thread Markus Korn
Public bug reported: While working on the wildcard implementation I had some hard time with our event_view view. And I'm esp. wondering why event.actor and event.subj_mimetype are ids where fields like event.subj_origin is already JOINed to the actual string. Is this on purpose? shouldn't be

[Zeitgeist] [Bug 485966] Re: Using filters (text match / exclusion / etc)

2010-05-14 Thread Markus Korn
** Branch linked: lp:~thekorn/zeitgeist/wildcard_support -- Using filters (text match / exclusion / etc) https://bugs.launchpad.net/bugs/485966 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/wildcard_support into lp:zeitgeist

2010-05-14 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/wildcard_support into lp:zeitgeist. Requested reviews: Mikkel Kamstrup Erlandsen (kamstrup) Zeitgeist Framework Team (zeitgeist) This branch adds wildcard-support to some template-fields, and completes the fix of bug 485966 --

[Zeitgeist] [Bug 580643] Re: conversion script for the database and database versioning

2010-05-14 Thread Markus Korn
*** This bug is a duplicate of bug 566898 *** https://bugs.launchpad.net/bugs/566898 added Mikkel's work on 1.) ** Changed in: zeitgeist Importance: Undecided = Critical ** Changed in: zeitgeist Status: New = Confirmed ** Changed in: zeitgeist Milestone: None = 0.3.4 ** This

Re: [Zeitgeist] [Bug 487321] Re: What value should subject.origin have?

2010-05-14 Thread Siegfried Gevatter
2010/5/14 Michal Hruby michal@gmail.com: Therefore the web page visit event could have as origin set -- the domain Completely agree. As for Mikkel's IM use case, I don't think it's ZG's job to log every message, so there'd be only some kind of CONVERSATION_STARTED event Completely agree.

Re: [Zeitgeist] [Bug 485966] Re: Using filters (text match / exclusion / etc)

2010-05-14 Thread Siegfried Gevatter
2010/5/14 Markus Korn thek...@gmx.de: Please cry out loud if you think that case sensitive searches is a bad thing. I'm crying out loud! (not really constructive, I know :P) -- Using filters (text match / exclusion / etc) https://bugs.launchpad.net/bugs/485966 You received this bug

Re: [Zeitgeist] [Bug 487321] Re: What value should subject.origin have?

2010-05-14 Thread Seif Lotfy
So lets say i switched from i opened a website the a document will the website be the origin of the document... if yes i think this is kinda wrong. since we are talking about a subject origin as opposed to what you are suggesting what i would call a event origin... Lets have an irc meeting... With