Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-19 Thread मनीष सिन्हा
@Stefano I reviewed yours. It's fine. Will merge it by end of the day -- https://code.launchpad.net/~kelemeng/activity-log-manager/bug958483/+merge/98096 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list:

Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-19 Thread मनीष सिन्हा
Review: Approve @Gabor Cool. Looks fine. Will merge both the branches. I just checked Stefano's diff. Will have a thorough look at the codebcase before making a release. -- https://code.launchpad.net/~kelemeng/activity-log-manager/bug958483/+merge/98096 Your team Activity Log Manager is

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist

2012-03-19 Thread Seif Lotfy
Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: Bug #950983 in Zeitgeist Framework: Storage monitor sets up weird storage ids https://bugs.launchpad.net/zeitgeist/+bug/950983 For

[Zeitgeist] [Bug 950983] Re: Storage monitor sets up weird storage ids

2012-03-19 Thread Seif Lotfy
** Branch linked: lp:~zeitgeist/zeitgeist/fix-950983 ** Changed in: zeitgeist Status: Triaged = In Progress -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/950983

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist

2012-03-19 Thread Michal Hruby
Review: Needs Fixing Can't we make it simpler? Try to INSERT the row, if that fails because the value already exists, run UPDATE. And arguably it might be more efficient to swap the order. -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176 Your team Zeitgeist Framework

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist

2012-03-19 Thread Michal Hruby
Review: Approve Looks good to me -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to :

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 435: Storage Monitor Extensions: fix bug lp:950983

2012-03-19 Thread noreply
revno: 435 committer: Seif Lotfy s...@lotfy.com branch nick: zeitgeist timestamp: Mon 2012-03-19 11:02:10 +0100 message: Storage Monitor Extensions: fix bug lp:950983 modified: extensions/storage-monitor.vala -- lp:zeitgeist

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 436: Storage Monitor Extension: refactor the INSERT OR REPLACE statement

2012-03-19 Thread noreply
revno: 436 committer: Seif Lotfy s...@lotfy.com branch nick: zeitgeist timestamp: Mon 2012-03-19 11:51:53 +0100 message: Storage Monitor Extension: refactor the INSERT OR REPLACE statement modified: extensions/storage-monitor.vala

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist

2012-03-19 Thread noreply
The proposal to merge lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176 --

[Zeitgeist] [Bug 950983] Re: Storage monitor sets up weird storage ids

2012-03-19 Thread Seif Lotfy
** Changed in: zeitgeist Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/950983 Title: Storage monitor sets up weird storage ids

[Zeitgeist] [Merge] lp:~cando/activity-log-manager/appdialog-fixes into lp:activity-log-manager

2012-03-19 Thread noreply
The proposal to merge lp:~cando/activity-log-manager/appdialog-fixes into lp:activity-log-manager has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~cando/activity-log-manager/appdialog-fixes/+merge/97629 --

[Zeitgeist] [Bug 799531] Re: API for deletion of events within a timerange?

2012-03-19 Thread Trever Fischer
** Changed in: zeitgeist Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/799531 Title: API for deletion of events within a

[Zeitgeist] [Bug 925637] Re: Folder blacklisted list should be enhanced to match with the prototype

2012-03-19 Thread Launchpad Bug Tracker
** Branch linked: lp:activity-log-manager -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/925637 Title: Folder blacklisted list should be enhanced to match with the

[Zeitgeist] [Bug 929644] Re: Add filesystem crawler support

2012-03-19 Thread Stefano Candori
Uh? Can you explain it a little more Manish? I don't remember such a feature... :) -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/929644 Title: Add filesystem crawler

[Zeitgeist] [Bug 958483] Re: Untranslated strings in a-l-m

2012-03-19 Thread मनीष सिन्हा
** Changed in: activity-log-manager Status: New = Fix Committed -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/958483 Title: Untranslated strings in a-l-m Status

[Zeitgeist] [Bug 957891] Re: Diagnostics tab i18n problems in a-l-m

2012-03-19 Thread मनीष सिन्हा
** Changed in: activity-log-manager Status: New = Fix Committed -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/957891 Title: Diagnostics tab i18n problems in a-l-m

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/fts-sorting into lp:zeitgeist

2012-03-19 Thread Michal Hruby
Review: Approve Looks fine. -- https://code.launchpad.net/~rainct/zeitgeist/fts-sorting/+merge/97985 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to :

[Zeitgeist] [Merge] lp:~rainct/zeitgeist/fts-sorting into lp:zeitgeist

2012-03-19 Thread Michal Hruby
The proposal to merge lp:~rainct/zeitgeist/fts-sorting into lp:zeitgeist has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~rainct/zeitgeist/fts-sorting/+merge/97985 -- https://code.launchpad.net/~rainct/zeitgeist/fts-sorting/+merge/97985

[Zeitgeist] [Bug 959615] [NEW] Sorting of LEAST_POPULAR_* result type

2012-03-19 Thread Siegfried Gevatter
Public bug reported: // FIXME: Why are LEAST_POPULAR_* using ASC? ** Affects: zeitgeist Importance: Undecided Status: New -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework.

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/fts-sorting into lp:zeitgeist

2012-03-19 Thread Michal Hruby
But perhaps the is_asc method should be a (static?) method of ResultType. -- https://code.launchpad.net/~rainct/zeitgeist/fts-sorting/+merge/97985 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list:

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 437: Fix typo in table-lookup comment.

2012-03-19 Thread noreply
revno: 437 committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com branch nick: bluebird timestamp: Mon 2012-03-19 20:12:41 +0100 message: Fix typo in table-lookup comment. modified: src/table-lookup.vala -- lp:zeitgeist

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Review: Abstain OK -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to :

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Review: Approve -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to :

[Zeitgeist] [Bug 929644] Re: Add filesystem crawler support

2012-03-19 Thread मनीष सिन्हा
Stefano. We had this in the python version where we used to iterate over ~ folder folders, take their timestamp and insert the modify event for that file. I talked to seif and he is now against this feature. He expressed that it spammed the db with useless files -- You received this bug

[Zeitgeist] [Bug 929644] Re: Add filesystem crawler support

2012-03-19 Thread मनीष सिन्हा
We should set this to Won't Fix. -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/929644 Title: Add filesystem crawler support Status in Activity Log Manager for

[Zeitgeist] [Bug 929644] Re: Add filesystem crawler support

2012-03-19 Thread Seif Lotfy
Yeah lets stay away from this for now -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/929644 Title: Add filesystem crawler support Status in Activity Log Manager for

[Zeitgeist] [Bug 929644] Re: Add filesystem crawler support

2012-03-19 Thread मनीष सिन्हा
** Changed in: activity-log-manager Status: Confirmed = Triaged -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/929644 Title: Add filesystem crawler support Status

[Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-19 Thread noreply
The proposal to merge lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~kelemeng/activity-log-manager/bug958483/+merge/98096 --

[Zeitgeist] [Bug 958483] Re: Untranslated strings in a-l-m

2012-03-19 Thread Launchpad Bug Tracker
** Branch linked: lp:activity-log-manager -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/958483 Title: Untranslated strings in a-l-m Status in Activity Log Manager for

Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Review: Needs Fixing Hi Trever, First of all, thank you for working on this! As commented on IRC, I don't really see a point for storage_state, num_events and result_type in the event deletion method. The original proposal just had time_range and event_templates. (I'm also unconvinced that

Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-19 Thread Trever Fischer
As noted in the original bug, simply querying all the event ids in a time range and then handing it to delete_events causes the SQL error described: Too many variables -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Siegfried Gevatter has proposed merging lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/fts-origin-hashing/+merge/98281 --

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Maybe move the md5 summing into a function? It's ugly :p -- https://code.launchpad.net/~zeitgeist/zeitgeist/fts-origin-hashing/+merge/98281 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist.

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/fts-sorting into lp:zeitgeist

2012-03-19 Thread Michal Hruby
Review: Approve Yey! -- https://code.launchpad.net/~rainct/zeitgeist/fts-sorting/+merge/97985 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to :

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 438: Refactor ResultType sorting and fix FTS++'s Search() with LeastRecent*

2012-03-19 Thread noreply
Merge authors: Siegfried Gevatter (rainct) revno: 438 [merge] committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com branch nick: bluebird timestamp: Mon 2012-03-19 20:56:38 +0100 message: Refactor ResultType sorting and

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 439: FTS++ test case: popularity is broken :(

2012-03-19 Thread noreply
revno: 439 committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com branch nick: bluebird timestamp: Mon 2012-03-19 22:15:57 +0100 message: FTS++ test case: popularity is broken :( modified:

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Review: Approve Lovely :) -- https://code.launchpad.net/~zeitgeist/zeitgeist/fts-origin-hashing/+merge/98281 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to :

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 440: Merge lp:~zeitgeist/zeitgeist/fts-origin-hashing

2012-03-19 Thread noreply
Merge authors: Michal Hruby (mhr3) Related merge proposals: https://code.launchpad.net/~zeitgeist/zeitgeist/fts-origin-hashing/+merge/98281 proposed by: Siegfried Gevatter (rainct) review: Approve - Siegfried Gevatter (rainct)

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist

2012-03-19 Thread noreply
The proposal to merge lp:~zeitgeist/zeitgeist/fts-origin-hashing into lp:zeitgeist has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/fts-origin-hashing/+merge/98281 --

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 441: Update NEWS.

2012-03-19 Thread noreply
revno: 441 committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com branch nick: bluebird timestamp: Mon 2012-03-19 22:52:42 +0100 message: Update NEWS. modified: NEWS -- lp:zeitgeist

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 442: Fix tests

2012-03-19 Thread noreply
revno: 442 committer: Michal Hruby michal@gmail.com branch nick: zeitgeist timestamp: Mon 2012-03-19 22:55:09 +0100 message: Fix tests modified: extensions/fts++/test/test-indexer.cpp -- lp:zeitgeist

[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 443: Fix FTS tests.

2012-03-19 Thread noreply
revno: 443 committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com branch nick: bluebird timestamp: Mon 2012-03-19 22:57:17 +0100 message: Fix FTS tests. modified: extensions/fts++/test/test-indexer.cpp -- lp:zeitgeist