Review: Approve
--
https://code.launchpad.net/~jbicha/activity-log-manager/fix-few-warnings/+merge/173626
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to :
The proposal to merge lp:~jbicha/activity-log-manager/fix-few-warnings into
lp:activity-log-manager has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/fix-few-warnings/+merge/173626
--
The proposal to merge
lp:~jbicha/activity-log-manager/rename-standalone-title-too into
lp:activity-log-manager has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/rename-standalone-title-too/+merge/173061
--
Manish Sinha (मनीष सिन्हा) has proposed merging
lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into
lp:activity-log-manager.
Requested reviews:
Rico Tzschichholz (ricotz)
Jeremy Bicha (jbicha)
Related bugs:
Bug #1198364 in Activity Log Manager: Exclude list should have smaller
The proposal to merge lp:~zeitgeist/activity-log-manager/smaller-exclude-icons
into lp:activity-log-manager has been updated.
Description changed to:
Fixes LP: #1198364 where exclude list has smaller icons
Looks like: http://i.imgur.com/zPwGMPp.png
For more details, see:
Review: Needs Fixing design
This looks promising, but all icons should be the same size. Folder and
document icons should be just as small as app icons.
--
https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678
Your team Zeitgeist Framework Team is
Review: Disapprove
I don't see the need in reducing the icon-sizes. The problem which you want to
fix is not caused by them. The underlying widget structure is statically sized
and therefore doesn't adapt to different font-sizes.
And yes, all icons should have the same sizes.
So this approach
Ah, I didn't read the bug report, sorry.
I think that for consistency, icons in this list should be laid out exactly the
same way as icons in menu items are. That does mean they should be smaller.
However, Rico is right that that wouldn't actually fix the vertical alignment
of the text. In the
This fix was merged more than 6 months ago and and it has yet to reach any
Ubuntu version.
I understand doing a release only for such a small fix is not really exciting,
but what is the point of writing patches if they may never reach users?
So, if no more work is planned on Activity Log
I will have a look at this patch and make sure it makes it on 0.9.7 release in
maybe a week. Thanks for bringing it to my notice.
At the moment the focus of development is a different branch, but I will apply
this patch to the focus of development branch
--
Thanks Manish, let me know if I need to submit a new merge request against any
other branch.
--
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556
Your team Activity Log Manager is subscribed to branch
lp:~activity-log-manager/activity-log-manager/vala.
It's fine. I can just merge it directly if ubuntu focus of development branch
does not have this patch applied
--
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556
Your team Activity Log Manager is subscribed to branch
Jeremy Bicha has proposed merging lp:~jbicha/activity-log-manager/fix-add-popup
into lp:activity-log-manager.
Requested reviews:
Activity Log Manager (activity-log-manager)
For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842
This way the
Review: Approve
--
https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to :
The proposal to merge lp:~jbicha/activity-log-manager/fix-add-popup into
lp:activity-log-manager has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842
--
15 matches
Mail list logo
