The proposal to merge lp:~thekorn/zeitgeist/fix-641100-min-max-use-index into
lp:zeitgeist has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~thekorn/zeitgeist/fix-641100-min-max-use-index/+merge/35786
Your team Zeitgeist Framework Team is requested to review the
Mikkel, thanks for doing the review,
yes, the case of an empty db is covered by our unittests and everything works
just fine.
(
MIN/MAX always return sth. even if the table it's operating on is empty
In [7]: con = sqlite3.connect(":memory:")
In [8]: con.execute("CREATE TABLE boo(x)")
Out[8]:
review approve
Looks good, i'm just wondering how it fares with an empty db? But I
guess the unit tests will catch this if it's an issue.
--
https://code.launchpad.net/~thekorn/zeitgeist/fix-641100-min-max-use-index/+merge/35786
Your team Zeitgeist Framework Team is requested to review the propos
Markus Korn has proposed merging
lp:~thekorn/zeitgeist/fix-641100-min-max-use-index into lp:zeitgeist.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
Related bugs:
#641100 ZeitgeistEngine.__init__(): statement to get last row id is not using
the index
https://bugs.launchpad.net/bu
4 matches
Mail list logo
