[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Markus Korn
Manish, is this (esp. the last few lines `"dbus.Array([], signature=dbus.Signature('y'))"`) something you get somewhere with real code (if so, please attach a minimal reproducer) or is it *just* loud thinking? payload is in fact an array of bytes, as defined in the dbus signature. You should not c

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Manish Sinha
Markus, I got this when trying to work on the new blacklist API. So you need to run the daemon from this branch. lp:~manishsinha/zeitgeist/reproduce-691167 and then need to run the following commands on the python console >>> sub = Subject.new_for_values() >> ev = Event.new_for_values(actor="appl

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Manish Sinha
Seif, I don't think we can ever hit a situation where we need to compare payloads. BTW just because we might never hit this situation doesn't make this bug void. A bug is a bug. ** Branch linked: lp:~manishsinha/zeitgeist/fix-691167 -- You received this bug notification because you are a member

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Markus Korn
Okidoki, thanks for the example - what we are doing in _zeitgeist.engine.datamodel.Event.get_plain() for payloads is indeed wrong. Let me clearify the purpose of this method, get_plain() is designed to change Event(template) objects in a way that they are dumpable by the pickle module. And we are

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Manish Sinha
Markus, Right now event matching doesn't take payload in to consideration. It matches only metadata and subjects. So till now it has never matched payload. So we can say that this bug does not affect blacklists. Blacklist implementation was where I noticed this bug Anyway I got the patch and requ

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Manish Sinha
Ah. I mean requested for a merge. Sorry for the grammar mistake -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Manish Sinha
** Description changed: In the event serialization format, the third array is array of bytes or ay as dbus signature. When an event enters an extension, it looks like Event([dbus.Array([u'', u'1292500628312', u'', u'', u'application://foo.desktop'], signature=dbus.Signature('s')), [Sub

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-17 Thread Manish Sinha
After talks with Markus and Seif, it is indeed a bug ** Changed in: zeitgeist Status: New => Confirmed ** Changed in: zeitgeist Assignee: (unassigned) => Manish Sinha (manishsinha) -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is s

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-17 Thread Seif Lotfy
** Changed in: zeitgeist Milestone: None => 0.7.0 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and sometimes

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-17 Thread Manish Sinha
** Changed in: zeitgeist Status: Confirmed => In Progress -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string an

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-20 Thread Seif Lotfy
I beg to differ. But seems to me that they are not working at all. I wrote a test case in the below diff where I insert an event with a payload and try to retrieve it again. This does not work on trunk guys -.- --- === modified file 'test/remote-test.py' --- test/remote-test.py 2010-09-22 18:44

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-20 Thread Seif Lotfy
** Changed in: zeitgeist Importance: Undecided => High -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and somet

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-20 Thread Seif Lotfy
OK I just summed up the situation. A payload is an array of bytes. An Array of bytes should not be translated into a string (encoding could be an issue, especially if a binary). Thus I prefer having a list of int -- You received this bug notification because you are a member of Zeitgeist Framewo

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-20 Thread Manish Sinha
MIkkel asked this question in the merge request https://code.launchpad.net/~manishsinha/zeitgeist/fix-691167/+merge/43948/comments/97974/ and my reply is that as a array of bytes, it is easy to have binary information in it e..g tarball, image, db-dump, but I have no clue how string can be represe

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-28 Thread Siegfried Gevatter
What's the difference between this bug and bug #692645? -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and sometim

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-01-11 Thread Seif Lotfy
** Changed in: zeitgeist Importance: High => Medium ** Changed in: zeitgeist Importance: Medium => Wishlist -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title:

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-01-17 Thread Seif Lotfy
** Changed in: zeitgeist Milestone: 0.7.0 => None -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and sometimes

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-01-19 Thread Seif Lotfy
** Changed in: zeitgeist Milestone: None => 0.8.0 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and sometimes

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-02-10 Thread Siegfried Gevatter
I think we can bump the Python dependency to Python 2.6 by now, and fix this the right way. -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is somet

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-02-10 Thread Seif Lotfy
+1 on that decision -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes mentioned as string and sometimes as array of bytes Status in Ze

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-04-12 Thread Seif Lotfy
OK guys lets close this tiny useless bug. Lets put python 2.6 as minimum requirement -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes me

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-04-18 Thread मनीष सिन्हा
** Changed in: zeitgeist Assignee: Manish Sinha (मनीष सिन्हा) (manishsinha) => (unassigned) -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-05-05 Thread Seif Lotfy
** Changed in: zeitgeist Assignee: (unassigned) => Seif Lotfy (seif) ** Branch linked: lp:~seif/zeitgeist/fix-691167 ** Branch unlinked: lp:~manishsinha/zeitgeist/reproduce-691167 ** Branch unlinked: lp:~manishsinha/zeitgeist/fix-691167 -- You received this bug notification because you ar

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-05-21 Thread Seif Lotfy
** Changed in: zeitgeist Assignee: Seif Lotfy (seif) => J.P. Lacerda (jplacerda) -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691167 Title: The payload is sometimes m

[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2011-05-21 Thread Seif Lotfy
We wont fix this until it is a real issue. If any1 want to fix it please do but we wont look into it now. Our current solution works pretty well :) ** Changed in: zeitgeist Status: In Progress => Won't Fix ** Changed in: zeitgeist Milestone: 0.8.0 => 0.8.1 -- You received this bug no

Re: [Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Seif Lotfy
How do you intend to blacklist events with specific payloads then ? On Thu, Dec 16, 2010 at 6:37 PM, Markus Korn wrote: > Manish, is this (esp. the last few lines `"dbus.Array([], > signature=dbus.Signature('y'))"`) something you get somewhere with real > code (if so, please attach a minimal rep

Re: [Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes

2010-12-16 Thread Seif Lotfy
I agree with Markus that we should not allow blacklists to take payloads into consideration However I think the fix is necessary for us. +1 for me tbh -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bu