The proposal to merge lp:~zeitgeist/zeitgeist/datasource-properties-fix into
lp:zeitgeist has been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~zeitgeist/zeitgeist/datasource-properties-fix/+merge/33775
Your team Zeitgeist Framework Team is subscribed to branch
lp:
Review: Approve
Looks good. I didn't actually run the unit tests but the diff is clean enough
that I don't think regressions are a big danger here.
Nice work!
--
https://code.launchpad.net/~zeitgeist/zeitgeist/datasource-properties-fix/+merge/33775
Your team Zeitgeist Framework Team is subscribe
Review: Needs Fixing
--
https://code.launchpad.net/~zeitgeist/zeitgeist/datasource-properties-fix/+merge/33775
Your team Zeitgeist Framework Team is requested to review the proposed merge of
lp:~zeitgeist/zeitgeist/datasource-properties-fix into lp:zeitgeist.
___
So far so good, but this new properties should be used in the existing code,
otherwise they are pretty much useless ;)
http://pastebin.ubuntu.com/484135/ has a few bits where the new properties
should be used
I guess some properties also need to be writable...
--
https://code.launchpad.net/~ze
Seif Lotfy has proposed merging
lp:~zeitgeist/zeitgeist/datasource-properties-fix into lp:zeitgeist.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
This is a fix for
https://bugs.edge.launchpad.net/zeitgeist/+bug/513295
pretty straight forward
tested in the Registry Extension Direct
5 matches
Mail list logo
