[Zeitgeist] [Merge] lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist

2012-01-27 Thread noreply
The proposal to merge lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~rainct/zeitgeist/find_storage_for_uri/+merge/90423 -- https://code.launchpad.net/~rainct/zeitgeist/find_stora

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist

2012-01-27 Thread Michal Hruby
Review: Approve 54 +else*/ if (uri_scheme in network_uri_schemes) Would be nice to add a linebreak there, but otherwise fine... -- https://code.launchpad.net/~rainct/zeitgeist/find_storage_for_uri/+merge/90423 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgei

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist

2012-01-27 Thread Michal Hruby
Review: Needs Fixing 38 +string uri_scheme = uri.substring (0, uri.index_of ("://")); There's File.get_uri_scheme() for that. 45 +Mount mount = file.find_enclosing_mount (); I'm really worried here, it's bringing back gvfs and I dont like that one bit,

[Zeitgeist] [Merge] lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist

2012-01-27 Thread Siegfried Gevatter
Siegfried Gevatter has proposed merging lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~rainct/zeitgeist/find_storage_for_uri/+merge/90423 -- https://code.launchpad.net/~rai