[Zeitgeist] [Merge] lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist

2010-12-08 Thread Seif Lotfy
The proposal to merge lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist has been updated. Status: Needs review => Rejected -- https://code.launchpad.net/~seif/zeitgeist/use-new-placeholders/+merge/42943 Your team Zeitgeist Framework Team is requested to review the proposed merge of

Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist

2010-12-07 Thread Siegfried Gevatter
2010/12/7 Mikkel Kamstrup Erlandsen : > I believe we use the current approach because the 'correct' one fails with > thousands of ids in the arguments Right. Further, this change would give us no real benefit, since we're already ensuring everything is a number. -- https://code.launchpad.net/~se

Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist

2010-12-07 Thread Mikkel Kamstrup Erlandsen
I believe we use the current approach because the 'correct' one fails with thousands of ids in the arguments On Dec 7, 2010 3:01 PM, "Seif Lotfy" wrote: > Seif Lotfy has proposed merging lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist. > > Requested reviews: > Zeitgeist Framework Team (z

[Zeitgeist] [Merge] lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist

2010-12-07 Thread Seif Lotfy
Seif Lotfy has proposed merging lp:~seif/zeitgeist/use-new-placeholders into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) The SQLite docs say: --- You shouldn’t assemble your query using Python’s string operations because doing so is insecure; it makes your program v