Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-26 Thread Siegfried Gevatter
(Follow up from IRC: the "too many variables" bug has already been fixed) -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: h

Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-19 Thread Trever Fischer
As noted in the original bug, simply querying all the event ids in a time range and then handing it to delete_events causes the SQL error described: "Too many variables" -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is s

Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-19 Thread Siegfried Gevatter
Review: Needs Fixing Hi Trever, First of all, thank you for working on this! As commented on IRC, I don't really see a point for storage_state, num_events and result_type in the event deletion method. The original proposal just had time_range and event_templates. (I'm also unconvinced that th

[Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-19 Thread Trever Fischer
The proposal to merge lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 -- https://code.launchpad.net/~tdfischer/zeitgei

[Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-13 Thread noreply
The proposal to merge lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 -- https://code.launchpad.net/~tdfischer/zeitgei

[Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist

2012-03-13 Thread Trever Fischer
Trever Fischer has proposed merging lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist with lp:~tdfischer/zeitgeist/common-where as a prerequisite. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: Bug #799531 in Zeitgeist Framework: "API for deletion of eve