://code.launchpad.net/~zeitgeist/zeitgeist/bb-extensions-conf/+merge/76902
Your team Zeitgeist Framework Team is requested to review the proposed merge of
lp:~zeitgeist/zeitgeist/bb-extensions-conf into
lp:~zeitgeist/zeitgeist/bluebird.
=== modified file 'extensions/blacklist.vala'
--- extensions
Review: Approve
1) I'd get rid of the get_name method, we can just use get_type().name()
2) if the extension needed something special, store/retrieve could be virtual
Other than that it looks fine, feel free to merge!
--
The proposal to merge lp:~zeitgeist/zeitgeist/bb-extensions-conf into
lp:~zeitgeist/zeitgeist/bluebird has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/bb-extensions-conf/+merge/76902
--
https://code.launchpad.net
Great. Thanks for the review.
1) Changed, wasn't quite happy with get_name.
2) I'd rather not, if they really need to do something weird they can add a new
function.
--
https://code.launchpad.net/~zeitgeist/zeitgeist/bb-extensions-conf/+merge/76902
Your team Zeitgeist Framework Team is
4 matches
Mail list logo
