Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/fix-655164 into
lp:zeitgeist.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
Related bugs:
#655164 Support more ResultType
https://bugs.launchpad.net/bugs/655164
This branch fixes bug #655164
Added new ResultTypes:
1)MostPo
The proposal to merge lp:~zeitgeist/zeitgeist/fix-655164 into lp:zeitgeist has
been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-655164/+merge/38077
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/fix-65516
I did not have time yet to check if the tests make sense, but let me give you a
few comments first:
> === modified file '_zeitgeist/engine/main.py'
> --- _zeitgeist/engine/main.py 2010-09-29 08:39:32 +
> +++ _zeitgeist/engine/main.py 2010-10-10 14:57:44 +
> @@ -370,7 +370,15 @@
>
On Mon, Oct 11, 2010 at 4:20 PM, Markus Korn wrote:
> I did not have time yet to check if the tests make sense, but let me give
> you a few comments first:
>
>
> > === modified file '_zeitgeist/engine/main.py'
> > --- _zeitgeist/engine/main.py 2010-09-29 08:39:32 +
> > +++ _zeitgeist/engine
Review: Approve code, unittests
Hi Seif,
thanks for working on this. It's looking good and all tests are working fine.
Feel free to do the merge.
Markus
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-655164/+merge/38077
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeit
5 matches
Mail list logo