Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-19 Thread Martin Sustrik
Dhammika, +// Check if we had an error in previous attempt. +if (unlikely (!(static_castT* (this)-next))) +return (size_t) -1; + I think this won't work. The next step of the decoding state machine is performed here irrespective of whether previous

Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-19 Thread Dhammika Pathirana
Hi Martin, On Wed, Jan 19, 2011 at 6:22 AM, Martin Sustrik sust...@250bpm.com wrote: Dhammika, +            //  Check if we had an error in previous attempt. +            if (unlikely (!(static_castT*  (this)-next))) +                return (size_t) -1; + I think this won't work. The next

Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-19 Thread Martin Sustrik
On 01/19/2011 05:44 PM, Dhammika Pathirana wrote: +// Check if we had an error in previous attempt. +if (unlikely (!(static_castT*(this)-next))) +return (size_t) -1; + I think this won't work. The next step of the decoding state machine is

Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-19 Thread Thijs Terlouw
From: Martin Sustrik sust...@250bpm.com Date: Thu, 20 Jan 2011 00:18:15 +0100 Subject: Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init Thijs, does this patch solve your problem? Martin The patch from Dhammika solved the problem. I tested it this morning and I

Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-19 Thread Martin Sustrik
On 01/20/2011 06:52 AM, Thijs Terlouw wrote: The patch from Dhammika solved the problem. I tested it this morning and I don't see any problems with nmap portscan anymore. Very nice little patch! Great! Applied to master. I've also tried your suggestion with ZMQ_LINGER and set ZMQ_LINGER on

Re: [zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-19 Thread Thijs Terlouw
On Thu, Jan 20, 2011 at 1:52 PM, Thijs Terlouw thijsterl...@gmail.com wrote: I've also tried your suggestion with ZMQ_LINGER and set ZMQ_LINGER on all sockets I have. Unfortunately I still have problems. It seems that after rebuild the zmq_socket, sometimes the zmq_poll function will not

[zeromq-dev] [PATCH] Fix handle connection reset during session init

2011-01-18 Thread Dhammika Pathirana
Patch to handle nmap version probes. Signed-off-by: Dhammika Pathirana dhamm...@gmail.com --- src/decoder.hpp|4 src/zmq_engine.cpp |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/decoder.hpp b/src/decoder.hpp index 9da6f72..80987a8 100644 ---