Re: [zeromq-dev] [PATCH] assert on 0 length messages

2010-08-28 Thread Pieter Hintjens
On Fri, Aug 27, 2010 at 5:16 PM, Dhammika Pathirana dhamm...@gmail.com wrote: Submitted under MIT/X11 license. Is it possible to make this a mailing list policy? Possibly, we'll look at that. My fear is that retroactively setting policy on an existing list is not safe. I'd rather create a

[zeromq-dev] [PATCH] assert on 0 length messages

2010-08-27 Thread Dhammika Pathirana
Hi, On receiving a new message, decoder inits a msg with size (*tmpbuf - 1). But a sender can craft a message such that *tmpbuf is 0 (ie. zmq::message_t msg((size_t)-1)). This creates a remote memory corruption in the receiver. Patch is a temporary fix, we need a better way to handle malformed

Re: [zeromq-dev] [PATCH] assert on 0 length messages

2010-08-27 Thread Pieter Hintjens
Dhammika, Thanks for this patch. Can you please (and sorry for the double effort) repost this and state that you license it under MIT/X11? Even a 1-line fix needs to be properly handled. We really need a better way to organize patches IMO... -Pieter On Fri, Aug 27, 2010 at 10:22 AM, Dhammika

Re: [zeromq-dev] [PATCH] assert on 0 length messages

2010-08-27 Thread Dhammika Pathirana
Submitted under MIT/X11 license. Is it possible to make this a mailing list policy? diff --git a/src/zmq_decoder.cpp b/src/zmq_decoder.cpp index 8e335c9..3b3e13b 100644 --- a/src/zmq_decoder.cpp +++ b/src/zmq_decoder.cpp @@ -55,6 +55,7 @@ bool zmq::zmq_decoder_t::one_byte_size_ready () else