Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-27 Thread Ilja Golshtein
Yes, enormous thanks to Dhammika & all. Before the patch I had difficulties even with demonstrating how my system supposed to work. Any reasonable load test caused a crash inside 0mq. Now it is gone. I think Dhammika's work worth releasing 2.0.10. 27.09.10, 16:14, "Martin Sustrik" : > Dhammik

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-27 Thread Martin Sustrik
Dhammika, Good work! Can you submit this patch under MIT/X11 so that I can apply it? Thanks. Martin > Calling pipe->read(msg) on a drained pipe returns a bad msg. > Following patch is against master, and is released under mit/x11 license. > > > diff --git a/src/ypipe.hpp b/src/ypipe.hpp > index

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-21 Thread Ilja Golshtein
Hello! According to valgrind there is no memory leaks. The only thing valgrind points at is uninitialized data == dev:~/projects/zmq-test1/build >valgrind --track-origins=yes ./zmq-test 5 ==3060== Memcheck, a memory error detector ==3060== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-20 Thread Dhammika Pathirana
Hi Thijs, On Mon, Sep 20, 2010 at 9:08 PM, Thijs Terlouw wrote: > From: Dhammika Pathirana > >> Calling pipe->read(msg) on a drained pipe returns a bad msg. >> Following patch is against master, and is released under mit/x11 license. > > thanks! I have also applied the patch to my 2.0.9 version

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-20 Thread Thijs Terlouw
From: Dhammika Pathirana > Calling pipe->read(msg) on a drained pipe returns a bad msg. > Following patch is against master, and is released under mit/x11 license. thanks! I have also applied the patch to my 2.0.9 version and it seems to work; so far no more crashes. Just as Jon and Ilja, I woul

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-20 Thread Dhammika Pathirana
Hi Jon, On Mon, Sep 20, 2010 at 11:27 AM, Jon Dyte wrote: > Dhammika Pathirana wrote: >> >> >> Calling pipe->read(msg) on a drained pipe returns a bad msg. >> Following patch is against master, and is released under mit/x11 license. >> >> > > Thanks, this patch appears to correct my crashing inpr

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-20 Thread Jon Dyte
Dhammika Pathirana wrote: > > > Calling pipe->read(msg) on a drained pipe returns a bad msg. > Following patch is against master, and is released under mit/x11 license. > > Thanks, this patch appears to correct my crashing inproc program as well, in the zmq_msg_close. I will need to remove the

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-19 Thread Ilja Golshtein
Dhammika, I confirm I cannot reproduce issue #64 and issue #79 with patched 2.0.7. Thanks. 20.09.10, 05:21, "Dhammika Pathirana" : > On Thu, Sep 16, 2010 at 2:54 AM, Ilja Golshtein wrote: > > Hello! > > > > I've logged issue http://github.com/zeromq/zeromq2/issues/issue/79 > > > > Basical

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-19 Thread Ilja Golshtein
20.09.10, 05:21, "Dhammika Pathirana" : > Calling pipe->read(msg) on a drained pipe returns a bad msg. > Following patch is against master, and is released under mit/x11 license. Could someone please clarify if the patch resolves the issue or just decrease possibility of the crash. I mean if

Re: [zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-19 Thread Dhammika Pathirana
On Thu, Sep 16, 2010 at 2:54 AM, Ilja Golshtein wrote: > Hello! > > I've logged issue http://github.com/zeromq/zeromq2/issues/issue/79 > > Basically server application crashes if number of incoming TCP (under zmq > control) connections are terminated. Looks like it does not matter what > server

[zeromq-dev] Crash if several TCP connections are closed simultaneously

2010-09-16 Thread Ilja Golshtein
Hello! I've logged issue http://github.com/zeromq/zeromq2/issues/issue/79 Basically server application crashes if number of incoming TCP (under zmq control) connections are terminated. Looks like it does not matter what server really does - it may be poll or recv. Speculatively it may be conne