Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-09-02 Thread Pieter Hintjens
OK, fair enough. Then I think we have this working. On Mon, Sep 2, 2013 at 7:34 PM, Min RK wrote: > > > On Sep 2, 2013, at 9:25, Pieter Hintjens wrote: > >> MinRK, >> >> I've just pushed a patch that fixes authentication for PLAIN and >> CURVE, and updated the test cases to match. >> >> It all w

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-09-02 Thread Min RK
On Sep 2, 2013, at 9:25, Pieter Hintjens wrote: > MinRK, > > I've just pushed a patch that fixes authentication for PLAIN and > CURVE, and updated the test cases to match. > > It all works as expected... :-) > > One thing about CURVE authentication; client keys are passed to the > ZAP handle

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-09-02 Thread Pieter Hintjens
MinRK, I've just pushed a patch that fixes authentication for PLAIN and CURVE, and updated the test cases to match. It all works as expected... :-) One thing about CURVE authentication; client keys are passed to the ZAP handler as 32 binary bytes. I'm wondering whether it would be nicer to pass

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-09-01 Thread Pieter Hintjens
That seems the simplest and cleanest result. We'll get authentication failed events via the ZAP handler, and we might see connection failed event at the client side too (via context monitor) but these should be invisible to message processing. -Pieter On Fri, Aug 30, 2013 at 11:50 PM, MinRK wrot

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-08-30 Thread MinRK
On Fri, Aug 30, 2013 at 1:37 PM, Pieter Hintjens wrote: > On Thu, Aug 29, 2013 at 1:32 AM, MinRK wrote: > > > Thanks. By closed, you mean the connecting peer (client) should be > closed, > > or the inner pipe on the server side? What should be the user-visible > > symptoms of failed authenticat

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-08-30 Thread Pieter Hintjens
On Thu, Aug 29, 2013 at 1:32 AM, MinRK wrote: > Thanks. By closed, you mean the connecting peer (client) should be closed, > or the inner pipe on the server side? What should be the user-visible > symptoms of failed authentication, both on the client side and the server > side, if any? I'm looki

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-08-28 Thread MinRK
On Sun, Aug 25, 2013 at 1:53 PM, Pieter Hintjens wrote: > Failed authentication should cause the socket to be closed. We'll take > a look at this. Thanks for catching it. > Thanks. By closed, you mean the connecting peer (client) should be closed, or the inner pipe on the server side? What shou

Re: [zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-08-25 Thread Pieter Hintjens
Failed authentication should cause the socket to be closed. We'll take a look at this. Thanks for catching it. On Sun, Aug 25, 2013 at 8:51 PM, MinRK wrote: > Hello, > > I'm working on [adding support](https://github.com/zeromq/pyzmq/pull/401) > for 3.3 bits in pyzmq, and I'm testing the authenti

[zeromq-dev] Is ZMQ_PLAIN authentication supposed to do anything?

2013-08-25 Thread MinRK
Hello, I'm working on [adding support](https://github.com/zeromq/pyzmq/pull/401) for 3.3 bits in pyzmq, and I'm testing the authentication mechanisms. I translated the [security test]( https://github.com/zeromq/libzmq/blob/master/tests/test_security.cpp) to Python and it ran just fine. However,