Re: [zeromq-dev] Question about constness

2012-07-28 Thread Sebastian Lauwers
On 07/27/2012 08:56 AM, Sebastian Lauwers wrote: > Very well, I'll try to provide a patch tomorrow. I guess I hadn't looked at the CPP API closely before answering to Ming, or offering a patch. I'm not seeing anything in that API that doesn't have proper constness applied. Apologies to Martin f

Re: [zeromq-dev] Question about constness

2012-07-26 Thread Sebastian Lauwers
On 27/07/12 08:33, Pieter Hintjens wrote: > I'd suggest leaving the C API as is, and improving the C++ API (in > https://github.com/zeromq/cppzmq). Very well, I'll try to provide a patch tomorrow. -S. ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.

Re: [zeromq-dev] Question about constness

2012-07-26 Thread Pieter Hintjens
On Tue, Jul 24, 2012 at 4:23 PM, Sebastian Lauwers wrote: > Checking the zeromq 3.2 RC [1], I see this still hasn't been > applied---I don't know what the project's policy would be regarding > "breaking" the 3.2 API after the first RC has been released. > Constness is used a handful of times in z

[zeromq-dev] Question about constness

2012-07-26 Thread Ming Ji
I was wrong that zmq_msg_copy does not destroy the original message. It just does a shadow copy. Still it is better to indicate if the functions might change the original message at API level. ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http

Re: [zeromq-dev] Question about constness

2012-07-25 Thread Sebastian Lauwers
Hi again, On 25/07/12 03:26, Ming Ji wrote: Could you share your interface, or C++ API patch? I can probably do a test run before you release it. I haven't written the C++ API patch yet, so that'll have to wait for the weekend or so, when I have a minute. I've attached two files that contain

[zeromq-dev] Question about constness

2012-07-25 Thread Ming Ji
Hi Sebastian, Thanks for pointing out the previous threads about this issue. I went through all three of them. I saw someone mentioned const_cast. I would say that is a good way for people who knows the implementation details. For general users, it is still not safe. For example, zmq_msg_copy w

Re: [zeromq-dev] Question about constness

2012-07-24 Thread Sebastian Lauwers
On 24 July 2012 06:47, Ming Ji wrote: > Hi all, Hi there, > I am new to ZeroMQ. I am actually not quite comfortable about the > constness in the API. You are not the only one. This has been discussed a few times already: http://lists.zeromq.org/pipermail/zeromq-dev/2010-October/007392.html htt

[zeromq-dev] Question about constness

2012-07-23 Thread Ming Ji
Hi all, I am new to ZeroMQ. I am actually not quite comfortable about the constness in the API. For example, size_t zmq_msg_size(zmq_msg_t* msg); In my opinion, it is better to do it this way: size_t zmq_msg_size(const zmq_msg_t* msg); because this function by definition only returns the siz