Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Richard Elling
Beautiful, ship it -- richard On Jun 6, 2011, at 6:56 PM, Eric Schrock wrote: > Good catch. For consistency, I updated the property description to match > "compressratio" exactly. > > - Eric > > On Mon, Jun 6, 2011 at 9:39 PM, Mark Musante wrote: > > minor quibble: compressratio uses a low

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Eric Schrock
Good catch. For consistency, I updated the property description to match "compressratio" exactly. - Eric On Mon, Jun 6, 2011 at 9:39 PM, Mark Musante wrote: > > minor quibble: compressratio uses a lowercase x for the description text > whereas the new prop uses an uppercase X > > -- Eric Schr

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Mark Musante
minor quibble: compressratio uses a lowercase x for the description text whereas the new prop uses an uppercase X On 6 Jun 2011, at 21:10, Eric Schrock wrote: > Webrev has been updated: > > http://dev1.illumos.org/~eschrock/cr/zfs-refratio/ > > - Eric > > -- > Eric Schrock > Delphix > > 2

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Eric Schrock
Webrev has been updated: http://dev1.illumos.org/~eschrock/cr/zfs-refratio/ - Eric -- Eric Schrock Delphix 275 Middlefield Road, Suite 50 Menlo Park, CA 94025 http://www.delphix.com ___ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Richard Elling
+1 On Jun 6, 2011, at 4:30 PM, Matthew Ahrens wrote: > Yeah that sounds great, we can have "refcompressratio" as the long name and > "refratio" as the short name, analogous to "compressratio" -> "ratio". > > --matt > > On Mon, Jun 6, 2011 at 4:18 PM, Eric Schrock wrote: > It's worth noting th

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Matthew Ahrens
Yeah that sounds great, we can have "refcompressratio" as the long name and "refratio" as the short name, analogous to "compressratio" -> "ratio". --matt On Mon, Jun 6, 2011 at 4:18 PM, Eric Schrock wrote: > It's worth noting that ZFS supports abbreviated names ("compression" -> > "compress", "c

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Eric Schrock
It's worth noting that ZFS supports abbreviated names ("compression" -> "compress", "compressratio" -> "ratio", etc). The short name is used in 'zfs list' column titles and can also be used as the property name. So maybe the full name should be "refcompressratio" as the long name and "refratio" a

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Haudy Kazemi
On 6/6/2011 5:02 PM, Richard Elling wrote: On Jun 6, 2011, at 2:54 PM, Yuri Pankov wrote: On Mon, Jun 06, 2011 at 02:19:50PM -0700, Matthew Ahrens wrote: I have implemented a new property for ZFS, "refratio", which is the compression ratio for referenced space (the "compressratio" is the ratio

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Richard Elling
On Jun 6, 2011, at 2:54 PM, Yuri Pankov wrote: > On Mon, Jun 06, 2011 at 02:19:50PM -0700, Matthew Ahrens wrote: >> I have implemented a new property for ZFS, "refratio", which is the >> compression ratio for referenced space (the "compressratio" is the ratio for >> used space). We are using this

Re: [zfs-discuss] [illumos-Developer] zfs refratio property

2011-06-06 Thread Yuri Pankov
On Mon, Jun 06, 2011 at 02:19:50PM -0700, Matthew Ahrens wrote: > I have implemented a new property for ZFS, "refratio", which is the > compression ratio for referenced space (the "compressratio" is the ratio for > used space). We are using this here at Delphix to figure out how much space > a fil