Re: [zones-discuss] zones code review

2010-01-19 Thread Edward Pilatowicz
On Tue, Jan 19, 2010 at 02:33:15PM -0700, Jerry Jelinek wrote: > On 01/19/10 14:00, Edward Pilatowicz wrote: > >>> perhaps it would make sense to add some "tokens" to the comments in > >>> brand_asm.h like: > >>> 32-BIT INTERPOSITION STACK > >>> 32-BIT LCALL/INT STACK > >>> 64-BIT INTERPO

Re: [zones-discuss] zones code review

2010-01-19 Thread Jerry Jelinek
On 01/19/10 14:00, Edward Pilatowicz wrote: perhaps it would make sense to add some "tokens" to the comments in brand_asm.h like: 32-BIT INTERPOSITION STACK 32-BIT LCALL/INT STACK 64-BIT INTERPOSITION STACK 64-BIT LCALL/INT STACK and then in the comments

Re: [zones-discuss] zones code review

2010-01-19 Thread Edward Pilatowicz
On Mon, Jan 18, 2010 at 12:51:27PM -0700, Jerry Jelinek wrote: > Ed, > > Thanks for reviewing this, my responses are inline. > > On 01/15/10 19:26, Edward Pilatowicz wrote: > >On Thu, Jan 14, 2010 at 09:18:20AM -0700, Jerry Jelinek wrote: > >>I need a code review for my proposed fix for: > >> > >>6

Re: [zones-discuss] SXCE b130 zoneadm attach -u error

2010-01-19 Thread Karl Rossing
I checked it again, and it seems to be ok. I'm wondering if the JIVE form is not stripping out some characters. So I grabbed the changes from the pipermail. http://mail.opensolaris.org/pipermail/zones-discuss/2009-December/005914.html It now seems to have worked. -- This message posted from ope

Re: [zones-discuss] SXCE b130 zoneadm attach -u error

2010-01-19 Thread Jerry Jelinek
On 01/18/10 19:25, Karl Rossing wrote: I made the change as per http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6905313 What changes? As of this morning the bug has no workaround or suggested fix listed? I'm still getting the following error: bash-4.0# zoneadm -z model attach -