Re: [zones-discuss] code review for 6911329

2009-12-18 Thread Frank Batschulat (Home)
On Thu, 17 Dec 2009 23:16:19 +0100, Dan Price wrote: >> On Thu, Dec 17, 2009 at 07:17:50PM +0100, Frank Batschulat (Home) wrote: >> > May I have 2 code reviewers for: >> > >> > 6911329 Incorrect code in kstat_delete causes panic >> > http://cr.opensolaris.org/~batschul/onnvkstat/ >> > >> > Descri

Re: [zones-discuss] code review for 6911329

2009-12-17 Thread Dan Price
On Thu 17 Dec 2009 at 01:58PM, Edward Pilatowicz wrote: > lgtm. > ed > > On Thu, Dec 17, 2009 at 07:17:50PM +0100, Frank Batschulat (Home) wrote: > > May I have 2 code reviewers for: > > > > 6911329 Incorrect code in kstat_delete causes panic > > http://cr.opensolaris.org/~batschul/onnvkstat/ > >

Re: [zones-discuss] code review for 6911329

2009-12-17 Thread Edward Pilatowicz
lgtm. ed On Thu, Dec 17, 2009 at 07:17:50PM +0100, Frank Batschulat (Home) wrote: > May I have 2 code reviewers for: > > 6911329 Incorrect code in kstat_delete causes panic > http://cr.opensolaris.org/~batschul/onnvkstat/ > > Description > > A colleague was looking into a crash and the reason t

Re: [zones-discuss] code review for 6911329

2009-12-17 Thread Jordan Vaughan
On 12/17/09 10:17 AM, Frank Batschulat (Home) wrote: May I have 2 code reviewers for: 6911329 Incorrect code in kstat_delete causes panic http://cr.opensolaris.org/~batschul/onnvkstat/ Description A colleague was looking into a crash and the reason turned out to be a NULL pointer dereference

[zones-discuss] code review for 6911329

2009-12-17 Thread Frank Batschulat (Home)
May I have 2 code reviewers for: 6911329 Incorrect code in kstat_delete causes panic http://cr.opensolaris.org/~batschul/onnvkstat/ Description A colleague was looking into a crash and the reason turned out to be a NULL pointer dereference in kstat_delete(): kstat_delete(kstat_t *ksp) { k