[jira] Commented: (ZOOKEEPER-516) add support for 10 minute test ie "pre-commit" test

[ https://issues.apache.org/jira/browse/ZOOKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754434#action_12754434 ] Hadoop QA commented on ZOOKEEPER-516: - -1 overall. Here are the results of testing

[jira] Created: (ZOOKEEPER-526) Change the access pattern in the DataNode from direct access to the use of getters and setters

Change the access pattern in the DataNode from direct access to the use of getters and setters -- Key: ZOOKEEPER-526 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5

[jira] Updated: (ZOOKEEPER-516) add support for 10 minute test ie "pre-commit" test

[ https://issues.apache.org/jira/browse/ZOOKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-516: --- Status: Patch Available (was: Open) > add support for 10 minute test ie "pre-commit" test

[jira] Updated: (ZOOKEEPER-516) add support for 10 minute test ie "pre-commit" test

[ https://issues.apache.org/jira/browse/ZOOKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-516: --- Status: Open (was: Patch Available) > add support for 10 minute test ie "pre-commit" test

[jira] Updated: (ZOOKEEPER-516) add support for 10 minute test ie "pre-commit" test

[ https://issues.apache.org/jira/browse/ZOOKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-516: --- Attachment: ZOOKEEPER-516.patch this patch gets the time under 10min for ant -Dtest.quic

[jira] Updated: (ZOOKEEPER-516) add support for 10 minute test ie "pre-commit" test

[ https://issues.apache.org/jira/browse/ZOOKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-516: --- Assignee: Patrick Hunt Status: Patch Available (was: Open) > add support for 10 min

Re: Accessing internal variables in DataNode and synchronization.

Hi Mahadev! Sounds good that you want getters and setters, it makes most things easier to reason about, even though it might add a couple of extra lines of code. The reason that I'm bringing up the synchronization is that some of the methods in the DataNode are synchronized, which I like if it me

Re: Accessing internal variables in DataNode and synchronization.

Hi Erik, There is no such reason for accessing variable without acess and getters. We should not be doing that. Its good to have getters and setters. The synchronization on DataNode is a safe lock that would prevent developers being concerned about finer locks and maintaining them. In our perfor

Accessing internal variables in DataNode and synchronization.

In most places in the server side code, internal variables are accessed directly via something like, node.parent... instead of making the variable private and using getters and setters, what is the purpose of this? Another question is why the synchronization on for example the DataNode is done on

[jira] Created: (ZOOKEEPER-525) Changing children Set to Set in DataNode

Changing children Set to Set in DataNode Key: ZOOKEEPER-525 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-525 Project: Zookeeper Issue Type: Improvement Components: se

[jira] Updated: (ZOOKEEPER-472) Making DataNode not instantiate a HashMap when the node is ephmeral

[ https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Holstad updated ZOOKEEPER-472: --- Attachment: zookeeper-472.patch I decided to take a lesser approach and just do what this