not quite that simple I'm afraid ;-) some good friday reading if you
haven't seen before
http://kerneltrap.org/node/11
perhaps we should use lindent on our code? whoops ... ;-)
Patrick
Benjamin Reed wrote:
i think we follow linux coding conventions. i think i wrote most of the
code using the
Ben, emacs? If so can you post your .emacs settings to the
"howtocontribute" page? Cuz by default my emacs seems to want to do 2
spaces indent...
Patrick
Benjamin Reed wrote:
i think we follow linux coding conventions. i think i wrote most of the
code using the linux emacs style.
ben
Steve
i think we follow linux coding conventions. i think i wrote most of the
code using the linux emacs style.
ben
Steve Cheng wrote:
Hi,
What are the C formatting conventions for ZooKeeper? Couldn't find anything
on the HowToContribute page.
Thank you,
Steven
No gratuitous reformatting. Would be nice to try and keep it looking
like the code we already have...
Patrick
Mahadev Konar wrote:
Hi Steven,
The most important is 4 space indentation (no tabs). Other than that, we
really don't have any specific guidelines on c code. Now that you mention
it,
Hi Steven,
The most important is 4 space indentation (no tabs). Other than that, we
really don't have any specific guidelines on c code. Now that you mention
it, it would be good to have one. But as of now, we do not have one.
Thanks
mahadev
On 10/23/09 5:01 PM, "Steve Cheng" wrote:
> Hi,
> W
Hi,
What are the C formatting conventions for ZooKeeper? Couldn't find anything
on the HowToContribute page.
Thank you,
Steven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769525#action_12769525
]
Hadoop QA commented on ZOOKEEPER-547:
-
-1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-547:
Attachment: ZOOKEEPER-547.patch
a minor change in the test so that buff is set to 0 when
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-547:
Status: Patch Available (was: Open)
> Sanity check in QuorumCnxn Manager and quorum com
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-547:
Status: Open (was: Patch Available)
> Sanity check in QuorumCnxn Manager and quorum com
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769506#action_12769506
]
Hadoop QA commented on ZOOKEEPER-547:
-
+1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-547:
Attachment: ZOOKEEPER-547.patch
added a testcase in QuorumpeerMainTest.
> Sanity check
[
https://issues.apache.org/jira/browse/ZOOKEEPER-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-547:
Status: Patch Available (was: Open)
> Sanity check in QuorumCnxn Manager and quorum com
[
https://issues.apache.org/jira/browse/ZOOKEEPER-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769209#action_12769209
]
Flavio Paiva Junqueira commented on ZOOKEEPER-512:
--
This is for retryin
14 matches
Mail list logo
