Instantiating HashSet for DataNode?

2009-07-14 Thread Erik Holstad
I'm not sure if I've miss read the code for the DataNode, but to me it looks like every node gets a set of children even though it might be an ephemeral node which cannot have children, so we are wasting 240 B for every one of those. Not sure if it makes a big difference, but just thinking that

Re: Instantiating HashSet for DataNode?

2009-07-14 Thread Mahadev Konar
Hi Erik, I am not sure if that would a considerable opitmization but even if you wanted to do it, it would be much more than just adding a check in the constructor (the serialization/deserialization would need to have specialized code). Right now all the datanodes are treated equally for

Re: Instantiating HashSet for DataNode?

2009-07-14 Thread Patrick Hunt
Erik, if you'd like enter a JIRA and take a whack at it go ahead. Perhaps a subclass of DataNode specific for ephemerals? That way it can handle any particulars - and should also minimize the number of if(children==null) type checks that would be needed. (don't neg. impact performance or b/w

Re: Instantiating HashSet for DataNode?

2009-07-14 Thread Erik Holstad
Will file Jira and have a stab at it when I get a little time. Thanks guys!