Patrick Hunt wrote:
Chris, please take a look at the patch on 293 asap and let us know if
you have any issues -- I will be spinning a new release once mahadev/ben
review and commit the change.
That looks great -- covers a bunch of things, thanks!
ps. I noticed you had some additional sugge
Chris, please take a look at the patch on 293 asap and let us know if
you have any issues -- I will be spinning a new release once mahadev/ben
review and commit the change.
Patrick
ps. I noticed you had some additional suggestions for the c code in
JIRA, thanks. FYI we do accept contributions
Chris, that's unfortunate re the version number (config.h), but I think
I see why that is -- config.h should only really be visible in the
implementation, not exposed through the includes.
I've created a JIRA for this:
https://issues.apache.org/jira/browse/ZOOKEEPER-293
We'll hold 3.1 for this
Hi --
Btw, the version is in the config.h file, generated by autotools, as
VERSION. We don't break that out as individual parameters but we can if
there is interest.
That's useful, I'd missed that. Thanks; that should work for me
for now.
Sorry ... on second glance, I'll have to retra
Benjamin Reed wrote:
you are correct we usually increment the version number on an API breakage.
in the olden days if you called a function with less parameters than
expected, a null would get passed. if this still happens we are ABI
compatible. (i haven't tried it though...)
Yeah, I wondere
ben
From: Chris Darroch [chr...@pearsoncmg.com]
Sent: Wednesday, February 04, 2009 11:27 AM
To: zookeeper-user@hadoop.apache.org
Subject: ZooKeeper 3.1 and C API/ABI
Hi --
I notice that 3.1.0 is on its way and it includes ZOOKEEPER-255 which
adds the Stat structure as a parameter t
Hi Chris, these are good points, thanks for the feedback.
For java we have the ability to deprecate so we do as you mention -
major version if the API changes in non-bw compatible way. However we
haven't been enforcing that constraint for the C interface, perhaps we
should. BTW, we do list 255
Hi --
I notice that 3.1.0 is on its way and it includes ZOOKEEPER-255 which
adds the Stat structure as a parameter to the zoo_set() C call. This is
a valuable change and I don't want to hold it up.
However, I thought I should point out that this kind of change
breaks the API and ABI. For m
