Re: ZooKeeper 3.1 and C API/ABI

2009-02-05 Thread Chris Darroch
Hi -- Btw, the version is in the config.h file, generated by autotools, as VERSION. We don't break that out as individual parameters but we can if there is interest. That's useful, I'd missed that. Thanks; that should work for me for now. Sorry ... on second glance, I'll have to

Re: ZooKeeper 3.1 and C API/ABI

2009-02-05 Thread Patrick Hunt
Chris, that's unfortunate re the version number (config.h), but I think I see why that is -- config.h should only really be visible in the implementation, not exposed through the includes. I've created a JIRA for this: https://issues.apache.org/jira/browse/ZOOKEEPER-293 We'll hold 3.1 for

Re: ZooKeeper 3.1 and C API/ABI

2009-02-05 Thread Patrick Hunt
Chris, please take a look at the patch on 293 asap and let us know if you have any issues -- I will be spinning a new release once mahadev/ben review and commit the change. Patrick ps. I noticed you had some additional suggestions for the c code in JIRA, thanks. FYI we do accept

Re: ZooKeeper 3.1 and C API/ABI

2009-02-05 Thread Chris Darroch
Patrick Hunt wrote: Chris, please take a look at the patch on 293 asap and let us know if you have any issues -- I will be spinning a new release once mahadev/ben review and commit the change. That looks great -- covers a bunch of things, thanks! ps. I noticed you had some additional

Re: ZooKeeper 3.1 and C API/ABI

2009-02-04 Thread Chris Darroch
Benjamin Reed wrote: you are correct we usually increment the version number on an API breakage. in the olden days if you called a function with less parameters than expected, a null would get passed. if this still happens we are ABI compatible. (i haven't tried it though...) Yeah, I