[Zope-dev] Undeclared dependency of zope.site on zope.app.publication

2009-09-23 Thread Thomas Lotze
I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site. I'd like to get rid of the dependency of zope.site on zope.app.publisher and I

Re: [Zope-dev] Undeclared dependency of zope.site on zope.app.publication

2009-09-23 Thread Michael Howitz
Am 23.09.2009 um 08:06 schrieb Thomas Lotze: I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site. I'd like to get rid of the

Re: [Zope-dev] Undeclared dependency of zope.site on zope.app.publication

2009-09-23 Thread Thomas Lotze
Michael Howitz wrote: Am 23.09.2009 um 08:06 schrieb Thomas Lotze: I just noticed that zope.site depends on zope.app.publication, both via configure.zcml and the tests. The dependency isn't currently declared. On the other hand, zope.app.publication doesn't yet depend on zope.site. I'd like

Re: [Zope-dev] zope.password

2009-09-23 Thread Wichert Akkerman
On 2009-9-22 18:59, Daniel Holth wrote: At least on Python 2.6, SSHAPasswordManager().checkPassword(hash, password) fails if hash is unicode, which it always is if stored in some databases. SSHAPasswordManager should encode the hash to utf-8 before trying to un-base64. Isn't that a bug in

Re: [Zope-dev] zope.password

2009-09-23 Thread Daniel Holth
sqlite for example will always return strings as unicode strings, or it will always return strings as byte strings. It doesn't know how to return the username colum as one kind of string and the hash column as another kind of string. I think this is really a bug in the urlsafe base64 module. This

Re: [Zope-dev] zope.password

2009-09-23 Thread Wichert Akkerman
On 2009-9-23 13:29, Daniel Holth wrote: sqlite for example will always return strings as unicode strings, or it will always return strings as byte strings. It doesn't know how to return the username colum as one kind of string and the hash column as another kind of string. SQLite is an

Re: [Zope-dev] zope.password

2009-09-23 Thread Daniel Holth
You are right, it is an accident that unicode can be encoded to base64. It just annoys me that the Python 2.6 error for this is TypeError: character mapping must return integer, None or unicode. In that case, how would you feel about updating PlainTextPasswordManager instead? It is not like the