Re: [Zope-dev] Zope 4 release management

2012-06-12 Thread Jan-Carel Brand
Hi Patrick On Mon, 2012-06-11 at 18:36 +0200, Patrick Gerken wrote: > Since I most often look for the history of something in SVN, I decided > to finally make a git mirror for myself to quickly find the history of > anything I might ever want. > Since its for history only, I just imported the c

Re: [Zope-dev] New release for zope.schema

2012-03-23 Thread Jan-Carel Brand
On Fri, 2012-03-23 at 13:12 +0100, Adam GROSZER wrote: > Hello, > > On Fri, 23 Mar 2012 12:53:51 +0100 you wrote: > > Hi Adam > > > > I guess you saw that Winbot is now happy again: > > http://winbot.zope.org/builders/zope.schema_py_265_32/builds/456 > > > > This means we need a 4.1.1 release, rig

Re: [Zope-dev] New release for zope.schema

2012-03-23 Thread Jan-Carel Brand
On Fri, 2012-03-23 at 12:29 +0100, Jan-Carel Brand wrote: > On Fri, 2012-03-23 at 12:16 +0100, Adam GROSZER wrote: > > Hello, > > > > On Thu, 22 Mar 2012 19:04:29 +0100 you wrote: > > > Ok, I'll release tomorrow morning when I'm fresh. > > > >

Re: [Zope-dev] New release for zope.schema

2012-03-23 Thread Jan-Carel Brand
On Fri, 2012-03-23 at 12:16 +0100, Adam GROSZER wrote: > Hello, > > On Thu, 22 Mar 2012 19:04:29 +0100 you wrote: > > Ok, I'll release tomorrow morning when I'm fresh. > > > > HOLD, winbot has a problem: > > FAILED : winbot / zope.schema_py_265_32 > Build: http://winbot.zope.org/builders/zope.sc

Re: [Zope-dev] New release for zope.schema

2012-03-23 Thread Jan-Carel Brand
On Thu, 2012-03-22 at 23:03 +0200, Marius Gedminas wrote: > On Thu, Mar 22, 2012 at 07:04:29PM +0100, Jan-Carel Brand wrote: > > On Thu, 2012-03-22 at 19:39 +0200, Marius Gedminas wrote: > > > $ virtualenv -p python3.2 py32 > > > $ py32/bin/python setup.py devel

Re: [Zope-dev] New release for zope.schema

2012-03-22 Thread Jan-Carel Brand
On Thu, 2012-03-22 at 19:39 +0200, Marius Gedminas wrote: > On Thu, Mar 22, 2012 at 03:27:20PM +0100, Jan-Carel Brand wrote: > > On Thu, 2012-03-22 at 12:19 +0100, Jan-Carel Brand wrote: > > > Thanks for the review. > > > > > > I've committed my changes

Re: [Zope-dev] New release for zope.schema

2012-03-22 Thread Jan-Carel Brand
On Thu, 2012-03-22 at 19:07 +0200, Marius Gedminas wrote: > On Thu, Mar 22, 2012 at 12:19:39PM +0100, Jan-Carel Brand wrote: > > On Wed, 2012-03-21 at 19:58 +0200, Marius Gedminas wrote: > > > Also, would you like to have PyPI access to zope.schema, so that you can > > &

Re: [Zope-dev] New release for zope.schema

2012-03-22 Thread Jan-Carel Brand
On Thu, 2012-03-22 at 12:19 +0100, Jan-Carel Brand wrote: > Thanks for the review. > > I've committed my changes and ran the tests with Python 2.6 and 2.7. > I don't have Python 3.x handy but will compile the latest and test with > that as well. Ok, I tested zope.s

Re: [Zope-dev] New release for zope.schema

2012-03-22 Thread Jan-Carel Brand
On Wed, 2012-03-21 at 19:58 +0200, Marius Gedminas wrote: > On Wed, Mar 21, 2012 at 05:29:44PM +0100, Jan-Carel Brand wrote: > > What needs to be done for a new release of zope.schema? (4.1) > > (Note: historically zope.schema always used three version components: > 4.

[Zope-dev] New release for zope.schema

2012-03-21 Thread Jan-Carel Brand
Hi folks What needs to be done for a new release of zope.schema? (4.1) And is there anything I can do to help speed it up? Even just an alpha/beta release would be very helpful. Thanks JC svn --non-interactive diff http://svn.zope.org/repos/main/zope.schema/tags/4.0.1 http://svn.zope.org/repos/m

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-02-06 Thread Jan-Carel Brand
On Mon, 2012-01-30 at 15:42 +0100, Charlie Clark wrote: > Am 30.01.2012, 14:33 Uhr, schrieb Jan-Carel Brand : > > ... lots cut ... > > > Yes, the values must be unique, because we do value lookups. > > The "title" attr doesn't have to be unique though. You

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-30 Thread Jan-Carel Brand
On Fri, 2012-01-27 at 11:50 +0100, Souheil CHELFOUH wrote: > Yes, Marius got exactly what I meant, this is how I usually make the > not-so-pluggable stuff pluggable :) > About the fact to release it out of zope.schema, it's also to be able > to make it live a bit and prove itself. > Then, including

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-30 Thread Jan-Carel Brand
On Sun, 2012-01-29 at 16:17 +0100, Charlie Clark wrote: > > From the zope.schema 4.0.0 release notes: > > "Port to Python 3. This adds a dependency on six and removes support for > > Python 2.5" > > Shouldn't that also mean a preference of > "for key in _dict" over "for key in _dict.keys()" ? >

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-27 Thread Jan-Carel Brand
On Thu, 2012-01-26 at 15:42 +0100, Charlie Clark wrote: > Hiya, > > Am 26.01.2012, 15:02 Uhr, schrieb Jan-Carel Brand : > > > Ok, Charlie also expressed his reservations. I'll put it in a different > > package then. > > Hang on a minute! While I'm not 1

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-26 Thread Jan-Carel Brand
t and implement an ordered tree from the start. > By the way, good work on that, it's something that is often needed in > advanced forms. I'll make sure to try it. > Thank you for the effort. Thanks! Much appreciated. J-C > > - Souheil > > 2012/1/25 Marius Ge

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-25 Thread Jan-Carel Brand
Hi Charlie On Wed, 2012-01-25 at 10:37 +0100, Charlie Clark wrote: > Hiya, > > Am 24.01.2012, 18:48 Uhr, schrieb Jan-Carel Brand : > > > I've clarified some of the docstrings and added the missing one. > > None have doctests, perhaps you are referring to fromDic

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-24 Thread Jan-Carel Brand
On Wed, 2012-01-25 at 00:52 +0200, Marius Gedminas wrote: > On Tue, Jan 24, 2012 at 07:34:03PM +0200, Jan-Carel Brand wrote: > > > Missing tests: by inheriting from SimpleVocabulary you also gain > > > .fromItems() and .fromValues(). Do those work? They pass a list of &g

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-24 Thread Jan-Carel Brand
Hi Charlie On Tue, 2012-01-24 at 15:06 +0100, Charlie Clark wrote: > Hiya, > Am 24.01.2012, 12:35 Uhr, schrieb Jan-Carel Brand : > > > Perhaps I should rephrase > > I would like my changes to be merged with the zope.schema trunk. The > > tests I've ad

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-24 Thread Jan-Carel Brand
On Tue, 2012-01-24 at 16:07 +0200, Marius Gedminas wrote: > Incidentally, please do not hijack existing threads when you start a new > topic, ok? Yes, that was an honest mistake, no ill intentions. Won't happen again. > On Tue, Jan 24, 2012 at 01:35:49PM +0200, Jan-Carel Brand wro

Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-24 Thread Jan-Carel Brand
On Fri, 2012-01-20 at 13:50 +0200, Jan-Carel Brand wrote: > Hi all > > I've been working on porting the Dynatree (a dynamic tree-like) widget > to z3c.form: > > https://github.com/collective/collective.dynatree > > My (temporary) fork is here: >

[Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-20 Thread Jan-Carel Brand
Hi all I've been working on porting the Dynatree (a dynamic tree-like) widget to z3c.form: https://github.com/collective/collective.dynatree My (temporary) fork is here: https://github.com/syslabcom/collective.dynatree And for this I needed a hierarchical tree-like vocabulary. So I've created