Re: [Zope-dev] Pluggable template engine

2011-08-13 Thread Malthe Borch
I will merge this branch if there are no objections. \malthe On 20 July 2011 17:24, Malthe Borch mbo...@gmail.com wrote: I've refactored the ``pagetemplate`` module to realistically support plugging in an alternative implementation of the parser and interpreter.  

Re: [Zope-dev] Pluggable template engine

2011-08-13 Thread Hanno Schlichting
On Sat, Aug 13, 2011 at 11:33 AM, Malthe Borch mbo...@gmail.com wrote: I will merge this branch if there are no objections. No objections - only thanks and cheers :) Hanno ___ Zope-Dev maillist - Zope-Dev@zope.org

Re: [Zope-dev] Pluggable template engine

2011-07-21 Thread Sylvain Viollon
Hello, On Wed, 20 Jul 2011 17:24:08 +0200 Malthe Borch mbo...@gmail.com wrote: I've refactored the ``pagetemplate`` module to realistically support plugging in an alternative implementation of the parser and interpreter.

Re: [Zope-dev] Pluggable template engine

2011-07-21 Thread Hanno Schlichting
On Wed, Jul 20, 2011 at 5:24 PM, Malthe Borch mbo...@gmail.com wrote: I'd like to propose merging this into trunk. +1 Hanno ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML

Re: [Zope-dev] Pluggable template engine

2011-07-21 Thread Leonardo Rochael Almeida
Hi Malthe, How often is the adaptation called? For example, suppose a Page Template had a tal:repeat that rendered a macro inside of it. If that tal:repeat looped 5 times, do we get 5 more adaptation calls, besides the call of the outermost Page Template? Just asking out of curiosity, I haven't

Re: [Zope-dev] Pluggable template engine

2011-07-21 Thread Malthe Borch
On 21 July 2011 16:19, Leonardo Rochael Almeida leoroch...@gmail.com wrote: How often is the adaptation called? Once per template render. No penalty for macros. \malthe ___ Zope-Dev maillist - Zope-Dev@zope.org

[Zope-dev] Pluggable template engine

2011-07-20 Thread Malthe Borch
I've refactored the ``pagetemplate`` module to realistically support plugging in an alternative implementation of the parser and interpreter. http://svn.zope.org/zope.pagetemplate/branches/engine-as-component/ Two new interfaces are added which serve as the plugging point see

Re: [Zope-dev] Pluggable template engine

2011-07-20 Thread Jim Fulton
What problem does this solve? Jim On Wed, Jul 20, 2011 at 11:24 AM, Malthe Borch mbo...@gmail.com wrote: I've refactored the ``pagetemplate`` module to realistically support plugging in an alternative implementation of the parser and interpreter.  

Re: [Zope-dev] Pluggable template engine

2011-07-20 Thread Malthe Borch
It makes it possible to use Chameleon with the stock template classes without monkey-patching the ``TALInterpreter`` class and ``_cook``. \malthe On 20 July 2011 17:43, Jim Fulton j...@zope.com wrote: What problem does this solve? Jim On Wed, Jul 20, 2011 at 11:24 AM, Malthe Borch